ottlinger commented on code in PR #249:
URL: https://github.com/apache/creadur-rat/pull/249#discussion_r1599793785
##########
apache-rat-core/src/main/java/org/apache/rat/license/LicenseSetFactory.java:
##########
@@ -161,8 +164,9 @@ public SortedSet<String> getLicenseFamilyIds(LicenseFilter
filter) {
* @param licenses the SortedSet of licenses to search.
* @return the matching license or {@code null} if not found.
*/
- public static ILicense search(String licenseId, SortedSet<ILicense>
licenses) {
- ILicenseFamily searchFamily =
ILicenseFamily.builder().setLicenseFamilyCategory(licenseId)
+ public static Optional<ILicense> search(String familyId, String licenseId,
SortedSet<ILicense> licenses) {
+ // return licenses.stream().filter( l ->
l.getId().equals(licenseId)).findFirst();
Review Comment:
LHF: rm old code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
