Claudenw opened a new pull request, #257:
URL: https://github.com/apache/creadur-rat/pull/257

   ** This code is not ready for merge as more tests for the generated Maven 
code need to be added **
   
   This is an early part of the Harmonization changes.
   
   Fixes for 
   - RAT-371 : converted URL collections to URI collections
   - RAT-382 : extracted CLI options into static class.
   - RAT-385 : generate base Ant code from CLI
   - RAT-386 : generate base Maven code from CLI
   
   This change moves the CLI Options code to its own class: `OptionCollection`
   
   The other major change is to add to apache-rat-tools the capability of 
generating base classes for Maven and Ant.  The base classes convert the CLI 
Option handling into Maven or Ant based abstract classes.  The strategy is to 
accept strings arguments in the Maven or Ant UI, create a CLI based command 
line array and call the `OptionCollection` code to create the base 
`ReportConfiguration` object.  The Maven and Ant classes then extend the 
abstract classes to handle the Maven and Ant specific options.
   
   The net result here is that if we define an Option (or deprecate an option) 
in CLI it flows down through the other implementations.  There are test cases 
that have to be added but changes in the core test code will force the code 
changes in the test cases for the derived classes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to