ottlinger commented on code in PR #257:
URL: https://github.com/apache/creadur-rat/pull/257#discussion_r1623268222
##########
apache-rat-plugin/src/main/java/org/apache/rat/mp/AbstractRatMojo.java:
##########
@@ -655,17 +664,19 @@ private List<IgnoreMatcher> mergeDefaultExclusions()
throws MojoExecutionExcepti
}
}
}
- if (excludesFile != null) {
- final File f = new File(excludesFile);
- if (!f.isFile()) {
- getLog().error("Excludes file not found: " +
f.getAbsolutePath());
- }
- if (!f.canRead()) {
- getLog().error("Excludes file not readable: " +
f.getAbsolutePath());
+ if (!excludesFileList.isEmpty()) {
+ for (String fileName : excludesFileList) {
+ final File f = new File(fileName);
+ if (!f.isFile()) {
+ getLog().error("Excludes file not found: " +
f.getAbsolutePath());
+ }
+ if (!f.canRead()) {
+ getLog().error("Excludes file not readable: " +
f.getAbsolutePath());
+ }
+ final String charset = excludesFileCharset == null ? "UTF8" :
excludesFileCharset;
Review Comment:
Should this be UTF-8 instead?
https://docs.oracle.com/javase/8/docs/api/java/nio/charset/Charset.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
