Looks like i broke the build by updating the site plugin. On Sat 28 Sept 2024, 13:27 Claudenw (via GitHub), <g...@apache.org> wrote:
> > Claudenw commented on code in PR #333: > URL: https://github.com/apache/creadur-rat/pull/333#discussion_r1779475719 > > > ########## > .github/workflows/maven.yml: > ########## > @@ -68,4 +68,4 @@ jobs: > run: ./mvnw -e -B -V -ntp javadoc:javadoc > > - name: Build site > - run: ./mvnw -e -B -V -ntp site > + run: ./mvnw -e -B -V -ntp site site:stage > > Review Comment: > see my comments above about the necessity for `package`, `site` and > `site:stage`. > > from the maven site plugin documentation: > ``` > Staging directory location. This needs to be an absolute path, like > C:\stagingArea\myProject\ on Windows or stagingArea/myProject/ on Unix. If > this is not specified, the site will be staged in ${project.build.directory} > staging. > User Property: stagingDirectory > ``` > > I redid my initial investigation and discovered that in the > distributionManagement/site section of the pom the URL is required even > though the plugin documentation would lead me to believe otherwise. The > URL in our case has several problems: > > - It can not be relative (as per the docs). Making it so causes a > staging directory to be created in every sub module. > - We can not specify a fully qualified directory since we do not know > directory or even OS for the varoious build systems. > > I did find that if an invalid URL is specified the default path as > specified in the documents will be used. thus `file:bogus` works. I am > changing that to `invalid:url` to be more clear and will add comments in > the pom to explain what is happening. I have also opened a [ticket]( > https://issues.apache.org/jira/browse/MSITE-1016) requesting a fix form > the site plugin team. > > > > > -- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > >
