Claudenw commented on code in PR #311:
URL: https://github.com/apache/creadur-rat/pull/311#discussion_r1794790525
##########
apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:
##########
@@ -418,7 +444,8 @@ public void setOut(final File file) {
DefaultLog.getInstance().warn("Unable to delete file: " +
file);
}
}
- if (!file.getParentFile().mkdirs()) {
+ File parent = file.getParentFile();
+ if (!parent.mkdirs() && !parent.isDirectory()) {
Review Comment:
I can go either way. I wrote it as not(isDirectory) because the message
also speaks in terms of "directory"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
