ottlinger commented on code in PR #311:
URL: https://github.com/apache/creadur-rat/pull/311#discussion_r1806996436
##########
apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/NoteGuesserTest.java:
##########
@@ -34,34 +39,24 @@ public void testMatches() {
assertTrue(NoteGuesser.isNote(new TestingDocument("NOTICE.txt")));
assertTrue(NoteGuesser.isNote(new TestingDocument("README")));
assertTrue(NoteGuesser.isNote(new TestingDocument("README.txt")));
- }
+ assertTrue(NoteGuesser.isNote(new
TestingDocument("src/test/DEPENDENCIES")));
+ assertTrue(NoteGuesser.isNote(new
TestingDocument("src/test/LICENSE")));
+ assertTrue(NoteGuesser.isNote(new
TestingDocument("src/test/LICENSE.txt")));
+ assertTrue(NoteGuesser.isNote(new TestingDocument("src/test/NOTICE")));
+ assertTrue(NoteGuesser.isNote(new
TestingDocument("src/test/NOTICE.txt")));
+ assertTrue(NoteGuesser.isNote(new TestingDocument("src/test/README")));
+ assertTrue(NoteGuesser.isNote(new
TestingDocument("src/test/README.txt")));
- @Test
- public void isNote() {
- assertTrue(NoteGuesser.isNote("DEPENDENCIES"));
- assertTrue(NoteGuesser.isNote("LICENSE"));
- assertTrue(NoteGuesser.isNote("LICENSE.txt"));
- assertTrue(NoteGuesser.isNote("NOTICE"));
- assertTrue(NoteGuesser.isNote("NOTICE.txt"));
- assertTrue(NoteGuesser.isNote("README"));
- assertTrue(NoteGuesser.isNote("README.txt"));
}
-
- @Test
- public void isNoteWithPath() {
- assertTrue(NoteGuesser.isNote("src/test/DEPENDENCIES"));
- assertTrue(NoteGuesser.isNote("src/test/LICENSE"));
- assertTrue(NoteGuesser.isNote("src/test/LICENSE.txt"));
- assertTrue(NoteGuesser.isNote("src/test/NOTICE"));
- assertTrue(NoteGuesser.isNote("src/test/NOTICE.txt"));
- assertTrue(NoteGuesser.isNote("src/test/README"));
- assertTrue(NoteGuesser.isNote("src/test/README.txt"));
- assertTrue(NoteGuesser.isNote("src\\test\\DEPENDENCIES"));
- assertTrue(NoteGuesser.isNote("src\\test\\LICENSE"));
- assertTrue(NoteGuesser.isNote("src\\test\\LICENSE.txt"));
- assertTrue(NoteGuesser.isNote("src\\test\\NOTICE"));
- assertTrue(NoteGuesser.isNote("src\\test\\NOTICE.txt"));
- assertTrue(NoteGuesser.isNote("src\\test\\README"));
- assertTrue(NoteGuesser.isNote("src\\test\\README.txt"));
+
+ @Disabled("RAT-390: old tests that do not work anymore")
Review Comment:
@Claudenw shouldn't these cases work as the normalisation is supposed to
remove path separators? I just reformatted the commented-out stuff and added it
here as the tests with backslashes do not recognise the files as a note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
