ottlinger commented on code in PR #366:
URL: https://github.com/apache/creadur-rat/pull/366#discussion_r1819864603
##########
apache-rat-core/src/main/java/org/apache/rat/configuration/XMLConfig.java:
##########
@@ -23,36 +23,36 @@
/**
* Configuration definitions for XMLConfiguration reader and writer.
*/
-public class XMLConfig {
+public final class XMLConfig {
/** id attribute name */
- public final static String ATT_ID = "id";
+ public static final String ATT_ID = "id";
/** name attribute name */
- public final static String ATT_NAME = "name";
+ public static final String ATT_NAME = "name";
/** license reference attribute name */
- public final static String ATT_LICENSE_REF = "license_ref";
+ public static final String ATT_LICENSE_REF = "license_ref";
/** class name attribute name */
- public final static String ATT_CLASS_NAME = "class";
+ public static final String ATT_CLASS_NAME = "class";
/** resource file name attribute name. */
- public final static String ATT_RESOURCE = "resource";
+ public static final String ATT_RESOURCE = "resource";
/** root of the configuration file */
- public final static String ROOT = "rat-config";
+ public static final String ROOT = "rat-config";
/** families element name */
- public final static String FAMILIES = "families";
+ public static final String FAMILIES = "families";
/** licenses element name */
- public final static String LICENSES = "licenses";
+ public static final String LICENSES = "licenses";
/** license element name */
- public final static String LICENSE = "license";
+ public static final String LICENSE = "license";
/** approved element name */
- public final static String APPROVED = "approved";
+ public static final String APPROVED = "approved";
/** family element name */
- public final static String FAMILY = "family";
+ public static final String FAMILY = "family";
/** note element name */
- public final static String NOTE = "note";
+ public static final String NOTE = "note";
Review Comment:
This constant is unused - does it get called via reflection or can we safely
remove it here? @Claudenw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
