ottlinger commented on code in PR #367: URL: https://github.com/apache/creadur-rat/pull/367#discussion_r1819877498
########## apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java: ########## @@ -41,9 +41,9 @@ import org.apache.rat.config.AddLicenseHeaders; import org.apache.rat.config.exclusion.ExclusionProcessor; import org.apache.rat.config.exclusion.StandardCollection; -import org.apache.rat.document.impl.DocumentName; -import org.apache.rat.document.impl.DocumentNameMatcher; -import org.apache.rat.document.impl.DocumentNameMatcherSupplier; +import org.apache.rat.document.DocumentName; Review Comment: @Claudenw Class has unused methods addIncludedFilter/addFamilies/addApprovedLicenseId() - do we need a reflection test for these as well or are they really unused? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org