[ https://issues.apache.org/jira/browse/RAT-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900631#comment-17900631 ]
ASF subversion and git services commented on RAT-246: ----------------------------------------------------- Commit 64c47d0f87a35144f662da4d54ba29d9460d6316 in creadur-rat's branch refs/heads/feature/RAT-397 from Claude Warren [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=64c47d0f ] RAT-246: .gitignore in parent dir not honored (#390) * initial fixes * Fixes to make checkstyle fail on warnings * Added checkstyle exclusions for site generation * initial changes * initial test implementation * initial core tests * initial core tests * fixed Maven issues * updated tests, example output and xsd. * update checks in Maven plugin testing * fixed integration tests in plugin * fixed spotbugs count error * fixed javadoc * fixed javadoc * RAT-399: Minor fixes * RAT-399: Add changelog and remove whitespace to fix the build * RAT-240: Add changelog about bugfix due to new ignore engine * Added additional info to ClaimValidator error logging * Added core integration test framework and integeration test for RAT-246 * RAT-246: Reformat poms * RAT-246: Minor fixes in Javadoc, prevent NPE * Minor fixes --------- Co-authored-by: P. Ottlinger <pottlin...@apache.org> Co-authored-by: P. Ottlinger <ottlin...@users.noreply.github.com> > .gitignore in parent dir not honored > ------------------------------------ > > Key: RAT-246 > URL: https://issues.apache.org/jira/browse/RAT-246 > Project: Apache Rat > Issue Type: Sub-task > Affects Versions: 0.12, 0.13 > Reporter: Ilya Basin > Assignee: Claude Warren > Priority: Minor > Fix For: 0.17 > > > Due to my Eclipse plugins set, when I import a maven project, a .checkstyle > file is generated there. As I learned later, RAT 0.13-SNAPSHOT ignores > .checkstyle files, so I repeated my tests with a different filename. > If a pattern is explicitly mentioned in the .gitignore in the project folder, > RAT does not complain. However, if the pattern is only mentioned in a parent > .gitignore, the RAT check fails. > {code:java} > [il@reallin wagon-scm]$ touch .someignoredfile > [il@reallin wagon-scm]$ echo .someignoredfile >>../../.gitignore > [il@reallin wagon-scm]$ git add .someignoredfile > The following paths are ignored by one of your .gitignore files: > wagon-providers/wagon-scm/.someignoredfile > Use -f if you really want to add them. > fatal: no files added > [il@reallin wagon-scm]$ mvn apache-rat:check > [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check > (default-cli) on project wagon-scm: Too many files with unapproved license: 1 > See RAT report in: target/rat.txt -> [Help 1] > [il@reallin wagon-scm]$ cat target/rat.txt > Files with unapproved licenses: > .someignoredfile > [il@reallin wagon-scm]$ echo .someignoredfile >>.gitignore > [il@reallin wagon-scm]$ mvn apache-rat:check > [INFO] BUILD SUCCESS > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)