ottlinger commented on PR #408: URL: https://github.com/apache/creadur-rat/pull/408#issuecomment-2522401065
Hi Jochen, you seem to have merged everything in master directly ..... the branch only contained the change of the gitignore file. Personally I'd prefer to have some sort of discussion about the proposed solution. Generally I'd question if it is really necessary to copy this manually crafted file at all .... Please use the infrastructure provided with GitHubActions: your newly created branch does not build as older JDK versions do not have the constructors that allow Charsets to be passed in. It should be easy to create a PR via Github to benefit fro automatically running builds and offer the opportunity for review of other committers. In case you do merges directly please add a changelog entry into src/changes/changes.xml. Cheers Phil Am 06.12.24 um 01:34 schrieb Jochen Wiedmann: > See RAT-379 <https://issues.apache.org/jira/browse/RAT-379> for details. > > ------------------------------------------------------------------------ > > > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/creadur-rat/pull/408 <https://github.com/ > apache/creadur-rat/pull/408> > > > Commit Summary > > * 641fc4e <https://github.com/apache/creadur-rat/pull/408/ > commits/641fc4e1db5ecaa0056016ce2082e162ec6a8447> RAT-453: updated > XSLT and example output (#405) > * 5c0cecc <https://github.com/apache/creadur-rat/pull/408/ > commits/5c0cecc9c9ee2a1da4000c1466c4f11bf1b3fb5f> Adding Eclipse > specific files to gitignore > > > File Changes > > (29 files <https://github.com/apache/creadur-rat/pull/408/files>) > > * *M* .gitignore <https://github.com/apache/creadur-rat/pull/408/ > files#diff- > bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947> (2) > * *M* apache-rat-core/src/it/resources/ReportTest/RAT_14/verify.groovy > <https://github.com/apache/creadur-rat/pull/408/ > files#diff-2d384c0bba142fddcd1dd3afc2d41c87bf59e50e2354d155c037f8ac8b81e491> (24) > * *M* apache-rat-core/src/it/resources/ReportTest/RAT_259/ > verify.groovy <https://github.com/apache/creadur-rat/pull/408/ > files#diff-688cee0e9dd806a823d4a753f523e30d2e87ae7962472279f0df1c6e4fba4bb2> (24) > * *M* apache-rat-core/src/it/resources/ReportTest/RAT_455/ > verify.groovy <https://github.com/apache/creadur-rat/pull/408/ > files#diff-17ee54bf360bbab676375a88990210e104212bda212e715dfa25f41b58db9dd3> (2) > * *M* apache-rat-core/src/it/resources/ReportTest/RAT_457/ > verify.groovy <https://github.com/apache/creadur-rat/pull/408/ > files#diff-5d240d6d4dadf7e3d30a214442aca07ed70cbd6649cb5505f22a65c5148d211d> (4) > * *M* apache-rat-core/src/main/resources/org/apache/rat/plain-rat.xsl > <https://github.com/apache/creadur-rat/pull/408/ > files#diff-910fa8fd49b54f766ed6524cea6a31b253c09ba63e7f1d2798e7f3f3b1b73305> (225) > * *M* apache-rat-core/src/site/apt/index.apt.vm <https://github.com/ > apache/creadur-rat/pull/408/ > files#diff-0d8025b914990ccfd466b335ec4c1ca1dd1dcda30fb5d8aeb3059aea0345ca23> (2) > * *M* apache-rat-core/src/test/java/org/apache/rat/ReporterTest.java > <https://github.com/apache/creadur-rat/pull/408/ > files#diff-0a16d247cabc8f45939769f25e4c8c3340149b6ee25a6793413ee65fcaa8882d> (123) > * *M* apache-rat-core/src/test/java/org/apache/rat/ > ReporterTestUtils.java <https://github.com/apache/creadur-rat/ > pull/408/files#diff- > d790e7c44a05dfcc4eb763c5ca64225e9b56f524bd56509a720329671086e8a1> (28) > * *M* apache-rat-plugin/pom.xml <https://github.com/apache/creadur- > rat/pull/408/ > files#diff-1b55c06852b055ac418ddc38b3e961d7a329311262c1181abf5a527148af055a> (1) > * *M* apache-rat-plugin/src/it/RAT-168/verify.groovy <https:// > github.com/apache/creadur-rat/pull/408/files#diff- > a5367e6c9a2f87bd5d3cae369cccdf35d4f4c933288a53734b083703e33ad579> (13) > * *M* apache-rat-plugin/src/it/RAT-314/verify.groovy <https:// > github.com/apache/creadur-rat/pull/408/files#diff- > e400f424537cd8afd665b16b48d15b3316af2770c3d67203631d3af6eca788d0> (16) > * *M* apache-rat-plugin/src/it/it1/verify.groovy <https://github.com/ > apache/creadur-rat/pull/408/files#diff- > b8c0250b1655cfabd0b69d1cf9e0e8b937140f9d97beceda2a3283a06b8689ba> (9) > * *M* apache-rat-plugin/src/main/java/org/apache/rat/mp/ > RatCheckMojo.java <https://github.com/apache/creadur-rat/pull/408/ > files#diff-8c06858642fd5e8a88ee3e51f54e4ae2ef15e94789a11a9cbacb5e3cc6e8c120> (4) > * *M* apache-rat-plugin/src/test/java/org/apache/rat/mp/ > RatCheckMojoTest.java <https://github.com/apache/creadur-rat/ > pull/408/ > files#diff-77d45cfce57b0145a3ce85d32368773dbc53825f75550a1f6b1e3ef7f35f6f34> (81) > * *M* apache-rat-tasks/src/test/java/org/apache/rat/anttasks/ > ReportTest.java <https://github.com/apache/creadur-rat/pull/408/ > files#diff- > e8b87bc8e43108aef65b3401b01a7bef442fb7229ac346d77aaea792f523e09f> (4) > * *M* apache-rat-tasks/src/test/resources/antunit/report-normal- > operation.xml <https://github.com/apache/creadur-rat/pull/408/ > files#diff-94f7d8fa186a9622693811f35da1c41722229cf0948a1ae4b4803280ae25b416> (14) > * *M* apache-rat-tools/pom.xml <https://github.com/apache/creadur-rat/ > pull/408/ > files#diff-9ec49ebc11388254b0cff8c35c297091f45141c027e9dd28606f790289a21883> (1) > * *M* apache-rat-tools/src/main/resources/Ant.tpl <https://github.com/ > apache/creadur-rat/pull/408/ > files#diff-248cac001489fa69b14c03897dbd9fce6331e1a5977193e1808f63518085bc97> (2) > * *M* apache-rat-tools/src/main/resources/Maven.tpl <https:// > github.com/apache/creadur-rat/pull/408/ > files#diff-6f385275f46f8fd7c783670534bcae0b98aa3e2ea8784badda1e6fdc47f5a016> (3) > * *D* apache-rat-tools/src/main/resources/ant/report.tpl <https:// > github.com/apache/creadur-rat/pull/408/files#diff- > e1305d46cd0df6d8d73b351812bfbd44eaea8bac5d719b580e4115dc435b2371> (14) > * *M* apache-rat/README-ANT.txt <https://github.com/apache/creadur- > rat/pull/408/files#diff- > dd42a464a09df41207972c0b0345f590e1906073d91dc5b23f08d75662de8681> (2) > * *M* apache-rat/src/site/apt/index.apt.vm <https://github.com/apache/ > creadur-rat/pull/408/ > files#diff-36182d49127e6887163d52d9c9b289279d3915d3f63905534687e1a0ad91ec15> (2) > * *M* apache-rat/src/site/apt/output/example.apt <https://github.com/ > apache/creadur-rat/pull/408/ > files#diff-3854e70e3a23fa9dac1ca43ac91dbc87b04a7ef1f1b906717a3ba4154b4c014f> (144) > * *M* apache-rat/src/site/examples/default_output.txt <https:// > github.com/apache/creadur-rat/pull/408/ > files#diff-8e0a85533b33ecbdbdc8b7e67da0e9e66695dc545adc900b35cd05056c8e7929> (118) > * *M* apache-rat/src/site/examples/rat-report.txt <https://github.com/ > apache/creadur-rat/pull/408/files#diff- > efb40142bab4b3e915407ad4e7b84f9bca665314604ccc6897b2d763776cde80> (193) > * *M* src/changes/changes.xml <https://github.com/apache/creadur-rat/ > pull/408/ > files#diff-480762ed7e0cb6175cb14bd289b7167eeac7ae35cf253725155eed73398da621> (3) > * *M* src/python/recursive-rat.py <https://github.com/apache/creadur- > rat/pull/408/files#diff- > f405df0dfa703e692281b2e2d5dc5e58005b3451dc0cc5ee021d9e026faecba6> (4) > * *M* src/site/apt/index.apt.vm <https://github.com/apache/creadur- > rat/pull/408/ > files#diff-85dce09d83956e168d3fdfc3bfe3119e82cb7d0e18083a0a475441337168fcee> (2) > > > Patch Links: > > * https://github.com/apache/creadur-rat/pull/408.patch <https:// > github.com/apache/creadur-rat/pull/408.patch> > * https://github.com/apache/creadur-rat/pull/408.diff <https:// > github.com/apache/creadur-rat/pull/408.diff> > > — > Reply to this email directly, view it on GitHub <https://github.com/ > apache/creadur-rat/pull/408>, or unsubscribe <https://github.com/ > notifications/unsubscribe-auth/ > AAKDA7SIUFZJMINZWICZEQL2EDWJNAVCNFSM6AAAAABTDT674WVHI2DSMVQWIX3LMV43ASLTON2WKOZSG4ZDCNZWGEYTANA>. > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
