ottlinger commented on code in PR #409: URL: https://github.com/apache/creadur-rat/pull/409#discussion_r1878507182
########## apache-rat-plugin/src/test/java/org/apache/rat/mp/RatCheckMojoTest.java: ########## @@ -265,35 +330,103 @@ public void testRAT_343() throws Exception { /** * Tests verifying gitignore parsing */ - public void testRAT_335GitIgnoreParsing() throws Exception { + public void /*test*/RAT_335GitIgnoreParsing() throws Exception { final RatCheckMojo mojo = newRatCheckMojo("RAT-335-GitIgnore"); final File ratTxtFile = mojo.getRatTxtFile(); - final String[] expected = { - ReporterTestUtils.counterText(ClaimStatistic.Counter.NOTICES, 1, false), - ReporterTestUtils.counterText(ClaimStatistic.Counter.BINARIES, 0, false), - ReporterTestUtils.counterText(ClaimStatistic.Counter.ARCHIVES, 0, false), - ReporterTestUtils.counterText(ClaimStatistic.Counter.STANDARDS, 6, false), - ReporterTestUtils.counterText(ClaimStatistic.Counter.GENERATED, 0, false), - ReporterTestUtils.counterText(ClaimStatistic.Counter.UNKNOWN, 4, false), - ReporterTestUtils.apacheLicenseVersion2(2), - ReporterTestUtils.unknownLicense(4), - ReporterTestUtils.documentOut(true, Document.Type.STANDARD, "/pom.xml") + - ReporterTestUtils.APACHE_LICENSE, - ReporterTestUtils.documentOut(false, Document.Type.STANDARD, "/dir1/dir1.md") + - ReporterTestUtils.UNKNOWN_LICENSE, - ReporterTestUtils.documentOut(false, Document.Type.STANDARD, "/dir2/dir2.txt") + - ReporterTestUtils.UNKNOWN_LICENSE, - ReporterTestUtils.documentOut(false, Document.Type.STANDARD, "/dir3/file3.log") + - ReporterTestUtils.UNKNOWN_LICENSE, - }; +// final String[] expected = { +// ReporterTestUtils.counterText(ClaimStatistic.Counter.NOTICES, 1, false), +// ReporterTestUtils.counterText(ClaimStatistic.Counter.BINARIES, 0, false), +// ReporterTestUtils.counterText(ClaimStatistic.Counter.ARCHIVES, 0, false), +// ReporterTestUtils.counterText(ClaimStatistic.Counter.STANDARDS, 6, false), +// ReporterTestUtils.counterText(ClaimStatistic.Counter.IGNORED, 0, false), +// ReporterTestUtils.counterText(ClaimStatistic.Counter.UNKNOWN, 4, false), Review Comment: Is this all due to RAT-355? @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org