raboof commented on code in PR #433:
URL: https://github.com/apache/creadur-rat/pull/433#discussion_r1939655695
##########
apache-rat-core/src/main/java/org/apache/rat/config/exclusion/StandardCollection.java:
##########
@@ -310,4 +310,18 @@ public boolean hasStaticDocumentNameMatcher() {
}
return false;
}
+
+ /** The location of the global gitignore file to process */
+ private static String globalGitIgnore() {
+ String xdgConfigHome = System.getenv("XDG_CONFIG_HOME");
+ if (xdgConfigHome != null && !xdgConfigHome.isEmpty()) {
+ return xdgConfigHome + File.pathSeparator + "git" +
File.pathSeparator + "ignore";
Review Comment:
> Would it make sense to provide this as a separate configuration option?
I'll have a look if/how that fits in the new structure Claude is preparing.
I think it'd make sense to follow what git does by default, but having a way to
suppress it could be good.
> I wonder if it takes too much time to find the global ignore file on all
platforms/operating systems upon each run. WDYT?
That sounds unlikely to me: finding it is only 1-2 environment variable
lookups and opening 1 file. Given RAT then proceeds to open *every* unignored
file in the repo, the extra time seems negligible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
