[
https://issues.apache.org/jira/browse/RAT-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18030970#comment-18030970
]
Bryan Ellis commented on RAT-337:
---------------------------------
[~pottlinger] I had joined the Creadur mailing list previously and have been
monitoring the activity and recent releases.
I can help out with taking care of the action.
I also submitted a PR to the current repository to add support for RAT 0.17. I
tested it and believe it is functioning properly. I will merge it in shortly.
I'm not sure if you noticed the PR or had a chance to read the details of the
changes I made.
Regarding your question in the testing repo:
> "Use new release of RAT: 0.17 – Does the action work with the new release?"
Typically, changing the requested version in the user's action YAML
configuration should be sufficient. However, RAT 0.17 introduced major breaking
changes that prevent this from working.
While the configuration might suggest that simply changing the version number
would be enough, it won't work in cases of significant breaking changes. After
I merge in my PR and create the 2.0.0 tag for the action, then users who wants
to use RAT 0.17 and newer would need to use 2.0.0 tag. In the case of ASF Infra
requirements, it would have to be the commit hash id, instead of the tag. Users
who wish to continue using, for example, 0.15.x or 0.16.x would need to use
version 1.2.0 of the action. I recall 0.15 and 0.16 didn't (?) have breaking
changes so they should be able to configure the version in their action.
Anyway, the tagging approach I mentioned above is just how it's currently done
in my repository. I'm not sure how you'd like to proceed within the ASF-Creadur
space. If we transfer the repository, I believe the existing tags would come
along with it. If you prefer a different tagging system—perhaps to align with
RAT's versioning—we would need to retag them accordingly.
> Apache RAT - GitHub Action
> --------------------------
>
> Key: RAT-337
> URL: https://issues.apache.org/jira/browse/RAT-337
> Project: Apache Rat
> Issue Type: Wish
> Reporter: Bryan Ellis
> Priority: Trivial
> Fix For: 1.0.0
>
>
> The Release Audit Tool is great for detecting "Unknown Licenses" when missing
> or when the header license is not Apache.
> In our Apache project, we are using this tool during our release process.
> Many times new files are created without license headers and not noticed
> until the release phase.
> For projects that use GitHub and GitHub Action workflows, I believe providing
> an action that can test on PR submission and push would be beneficial.
> Here is a GitHub Action composite workflow that was created to achieve this
> goal.
> https://github.com/erisu/apache-rat-action
> And here is the repo I used to test the above action.
> https://github.com/erisu/apache-rat-action-test
> This action only runs on Linux and could be updated to work on macOS. The way
> it is currently written will not work on Windows.
> If you think this action is useful and would like to take ownership, I could
> transfer the repo.
> In the above example the GitHub Action usage is:
> {code:java}
> - uses: erisu/apache-rat-action@v1
> {code}
> And if transfered and properly tagged, it could become:
> {code:java}
> - uses: apache/creadur-rat-action@v1
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
