[ 
https://issues.apache.org/jira/browse/RAT-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philipp Ottlinger updated RAT-501:
----------------------------------
    Description: 
After pushing the release I wanted to make RAT dog food itself .... and ran 
into minor problems on the existing source tree.

h2. Core submodule

Recognizes GPL-licenses albeit ASF license header is added:

! /src/main/resources/org/apache/rat/default.xml
  S         application/xml    UTF-8
    AL       AL1.1         Apache License 1.1
    AL       AL2.0         Apache License 2.0
    BSD-3    DOJO          DOJO License
    CDDL1    CDDL1         COMMON DEVELOPMENT AND DISTRIBUTION LICENSE Version 
1.0
    CDDL1    ILLUMOS       ILLUMOS CDDL1 Derived license
    GPL      GPL1          GNU General Public License V1.0 (Unapproved)
    GPL      GPL2          GNU General Public License V2.0 (Unapproved)
    GPL      GPL3          GNU General Public License V3.0 (Unapproved)
    MIT      MIT           The MIT License
    W3C      W3C           W3C Software Copyright
    W3CD     W3CD          W3C Document Copyright
  
! /src/main/resources/org/apache/rat/example-configuration.xml
  S         application/xml    UTF-8
    AL       AL1.1         Apache License 1.1
    AL       AL2.0         Apache License 2.0
    BSD-3    DOJO          DOJO License
    CDDL1    CDDL1         COMMON DEVELOPMENT AND DISTRIBUTION LICENSE Version 
1.0
    CDDL1    ILLUMOS       ILLUMOS CDDL1 Derived license
    GPL      GPL1          GNU General Public License V1.0 (Unapproved)
    GPL      GPL2          GNU General Public License V2.0 (Unapproved)
    GPL      GPL3          GNU General Public License V3.0 (Unapproved)
    MIT      MIT           The MIT License
    W3C      W3C           W3C Software Copyright
    W3CD     W3CD          W3C Document Copyright


! /src/test/java/org/apache/rat/analysis/license/GPLLicenseTest.java
  S         text/x-java-source    ISO-8859-1
    AL       AL2.0         Apache License 2.0
    GPL      GPL1          GNU General Public License V1.0 (Unapproved)
    GPL      GPL2          GNU General Public License V2.0 (Unapproved)
    GPL      GPL3          GNU General Public License V3.0 (Unapproved)

! /src/test/java/org/apache/rat/ReporterOptionsProvider.java
  S         text/x-java-source    ISO-8859-1
    AL       AL2.0         Apache License 2.0
    BSD-3    BSD-3         BSD 3 clause
    CDDL1    ILLUMOS       ILLUMOS CDDL1 Derived license
    GPL      GPL1          GNU General Public License V1.0 (Unapproved)

h2. Possible hints of configuration errors in site build

[WARNING] Basedir is : /home/me/creadur-rat/apache-rat
[INFO] Excluding patterns: src/site/examples/**, src/site/apt/*.txt
[INFO] Excluding MAVEN collection.
[INFO] Excluding ECLIPSE collection.
[INFO] Excluding IDEA collection.
[INFO] Processing exclude file from STANDARD_SCMS.
[INFO] Excluding STANDARD_SCMS collection.
[INFO] Excluding MISC collection.
[INFO] Excluding HIDDEN_DIR collection.
[WARNING] Duplicate LicenseFamily category: AL    (action: IGNORE)
[WARNING] Duplicate LicenseFamily category: BSD-3 (action: IGNORE)
[WARNING] Duplicate LicenseFamily category: CDDL1 (action: IGNORE)
[WARNING] Duplicate LicenseFamily category: GPL   (action: IGNORE)
[WARNING] Duplicate LicenseFamily category: MIT   (action: IGNORE)
[WARNING] Duplicate LicenseFamily category: OASIS (action: IGNORE)
[WARNING] Duplicate LicenseFamily category: W3C   (action: IGNORE)
[WARNING] Duplicate LicenseFamily category: W3CD  (action: IGNORE)
[WARNING] Duplicate License Apache License 1.0 (AL1.0) of type AL    (action: 
IGNORE)
[WARNING] Duplicate License Apache License 1.1 (AL1.1) of type AL    (action: 
IGNORE)
[WARNING] Duplicate License Apache License 2.0 (AL2.0) of type AL    (action: 
IGNORE)
[WARNING] Duplicate License BSD 3 clause (BSD-3) of type BSD-3 (action: IGNORE)
[WARNING] Duplicate License DOJO License (DOJO) of type BSD-3 (action: IGNORE)
[WARNING] Duplicate License The Telemanagement Forum License (TMF) of type 
BSD-3 (action: IGNORE)
[WARNING] Duplicate License COMMON DEVELOPMENT AND DISTRIBUTION LICENSE Version 
1.0 (CDDL1) of type CDDL1 (action: IGNORE)
[WARNING] Duplicate License ILLUMOS CDDL1 Derived license (ILLUMOS) of type 
CDDL1 (action: IGNORE)
[WARNING] Duplicate License GNU General Public License V1.0 (GPL1) of type GPL  
 (action: IGNORE)
[WARNING] Duplicate License GNU General Public License V2.0 (GPL2) of type GPL  
 (action: IGNORE)
[WARNING] Duplicate License GNU General Public License V3.0 (GPL3) of type GPL  
 (action: IGNORE)
[WARNING] Duplicate License The MIT License (MIT) of type MIT   (action: IGNORE)
[WARNING] Duplicate License OASIS Open License (OASIS) of type OASIS (action: 
IGNORE)
[WARNING] Duplicate License W3C Software Copyright (W3C) of type W3C   (action: 
IGNORE)
[WARNING] Duplicate License W3C Document Copyright (W3CD) of type W3CD  
(action: IGNORE)
[INFO] Excluding MISC collection.
[INFO] Excluding HIDDEN_DIR collection.
[INFO] Generating "SpotBugs" report             --- 
spotbugs-maven-plugin:4.8.6.6:spotbugs
[INFO] Generating "Project Information" report  --- 
maven-site-plugin:3.21.0:project-info
[INFO] Generating "Generated Reports" report    --- 
maven-site-plugin:3.21.0:project-reports

maybe that's the reason for the problems.

h2. Workaround / commit b421d0894f46ad6317d9f4af63a7f1680fcc886b

In order to not break the build the following files are ignored (as they are 
parsed as GPL):
* default.xml
* example-configuration.xml
* ReporterOptionsProvider.java
* GPLLicenseTest.java

h2. Solution

As RAT0.17 marks GPL as unapproved by default (=breaking change to earlier 
releases) the plugin marks any files with GPL-contents as UNAPPROVED,
thus:
* ReporterOptionsProvider.java
* GPLLicenseTest.java

are marked as unapproved during plugin runs.

XML files are reported and marked differently due to Tika recognition described 
in RAT-502.

Augment eclipse default excludes to include during analysis:
* "**/.externalToolBuilders/**" and
*  "**/bin/**"


  was:
After pushing the release I wanted to make RAT dog food itself .... and ran 
into minor problems on the existing source tree.

h2. Core submodule

Recognizes GPL-licenses albeit ASF license header is added:

! /src/main/resources/org/apache/rat/default.xml
  S         application/xml    UTF-8
    AL       AL1.1         Apache License 1.1
    AL       AL2.0         Apache License 2.0
    BSD-3    DOJO          DOJO License
    CDDL1    CDDL1         COMMON DEVELOPMENT AND DISTRIBUTION LICENSE Version 
1.0
    CDDL1    ILLUMOS       ILLUMOS CDDL1 Derived license
    GPL      GPL1          GNU General Public License V1.0 (Unapproved)
    GPL      GPL2          GNU General Public License V2.0 (Unapproved)
    GPL      GPL3          GNU General Public License V3.0 (Unapproved)
    MIT      MIT           The MIT License
    W3C      W3C           W3C Software Copyright
    W3CD     W3CD          W3C Document Copyright
  
! /src/main/resources/org/apache/rat/example-configuration.xml
  S         application/xml    UTF-8
    AL       AL1.1         Apache License 1.1
    AL       AL2.0         Apache License 2.0
    BSD-3    DOJO          DOJO License
    CDDL1    CDDL1         COMMON DEVELOPMENT AND DISTRIBUTION LICENSE Version 
1.0
    CDDL1    ILLUMOS       ILLUMOS CDDL1 Derived license
    GPL      GPL1          GNU General Public License V1.0 (Unapproved)
    GPL      GPL2          GNU General Public License V2.0 (Unapproved)
    GPL      GPL3          GNU General Public License V3.0 (Unapproved)
    MIT      MIT           The MIT License
    W3C      W3C           W3C Software Copyright
    W3CD     W3CD          W3C Document Copyright


! /src/test/java/org/apache/rat/analysis/license/GPLLicenseTest.java
  S         text/x-java-source    ISO-8859-1
    AL       AL2.0         Apache License 2.0
    GPL      GPL1          GNU General Public License V1.0 (Unapproved)
    GPL      GPL2          GNU General Public License V2.0 (Unapproved)
    GPL      GPL3          GNU General Public License V3.0 (Unapproved)

! /src/test/java/org/apache/rat/ReporterOptionsProvider.java
  S         text/x-java-source    ISO-8859-1
    AL       AL2.0         Apache License 2.0
    BSD-3    BSD-3         BSD 3 clause
    CDDL1    ILLUMOS       ILLUMOS CDDL1 Derived license
    GPL      GPL1          GNU General Public License V1.0 (Unapproved)

h2. Possible hints of configuration errors in site build

[WARNING] Basedir is : /home/me/creadur-rat/apache-rat
[INFO] Excluding patterns: src/site/examples/**, src/site/apt/*.txt
[INFO] Excluding MAVEN collection.
[INFO] Excluding ECLIPSE collection.
[INFO] Excluding IDEA collection.
[INFO] Processing exclude file from STANDARD_SCMS.
[INFO] Excluding STANDARD_SCMS collection.
[INFO] Excluding MISC collection.
[INFO] Excluding HIDDEN_DIR collection.
[WARNING] Duplicate LicenseFamily category: AL    (action: IGNORE)
[WARNING] Duplicate LicenseFamily category: BSD-3 (action: IGNORE)
[WARNING] Duplicate LicenseFamily category: CDDL1 (action: IGNORE)
[WARNING] Duplicate LicenseFamily category: GPL   (action: IGNORE)
[WARNING] Duplicate LicenseFamily category: MIT   (action: IGNORE)
[WARNING] Duplicate LicenseFamily category: OASIS (action: IGNORE)
[WARNING] Duplicate LicenseFamily category: W3C   (action: IGNORE)
[WARNING] Duplicate LicenseFamily category: W3CD  (action: IGNORE)
[WARNING] Duplicate License Apache License 1.0 (AL1.0) of type AL    (action: 
IGNORE)
[WARNING] Duplicate License Apache License 1.1 (AL1.1) of type AL    (action: 
IGNORE)
[WARNING] Duplicate License Apache License 2.0 (AL2.0) of type AL    (action: 
IGNORE)
[WARNING] Duplicate License BSD 3 clause (BSD-3) of type BSD-3 (action: IGNORE)
[WARNING] Duplicate License DOJO License (DOJO) of type BSD-3 (action: IGNORE)
[WARNING] Duplicate License The Telemanagement Forum License (TMF) of type 
BSD-3 (action: IGNORE)
[WARNING] Duplicate License COMMON DEVELOPMENT AND DISTRIBUTION LICENSE Version 
1.0 (CDDL1) of type CDDL1 (action: IGNORE)
[WARNING] Duplicate License ILLUMOS CDDL1 Derived license (ILLUMOS) of type 
CDDL1 (action: IGNORE)
[WARNING] Duplicate License GNU General Public License V1.0 (GPL1) of type GPL  
 (action: IGNORE)
[WARNING] Duplicate License GNU General Public License V2.0 (GPL2) of type GPL  
 (action: IGNORE)
[WARNING] Duplicate License GNU General Public License V3.0 (GPL3) of type GPL  
 (action: IGNORE)
[WARNING] Duplicate License The MIT License (MIT) of type MIT   (action: IGNORE)
[WARNING] Duplicate License OASIS Open License (OASIS) of type OASIS (action: 
IGNORE)
[WARNING] Duplicate License W3C Software Copyright (W3C) of type W3C   (action: 
IGNORE)
[WARNING] Duplicate License W3C Document Copyright (W3CD) of type W3CD  
(action: IGNORE)
[INFO] Excluding MISC collection.
[INFO] Excluding HIDDEN_DIR collection.
[INFO] Generating "SpotBugs" report             --- 
spotbugs-maven-plugin:4.8.6.6:spotbugs
[INFO] Generating "Project Information" report  --- 
maven-site-plugin:3.21.0:project-info
[INFO] Generating "Generated Reports" report    --- 
maven-site-plugin:3.21.0:project-reports

maybe that's the reason for the problems.

h2. Workaround / commit b421d0894f46ad6317d9f4af63a7f1680fcc886b

In order to not break the build the following files are ignored (as they are 
parsed as GPL):
* default.xml
* example-configuration.xml
* ReporterOptionsProvider.java
* GPLLicenseTest.java

h2. Solution

As RAT0.17 marks GPL as unapproved by default (=breaking change to earlier 
releases) the plugin marks any files with GPL-contents as UNAPPROVED,
thus:
* ReporterOptionsProvider.java
* GPLLicenseTest.java

are marked as unapproved during plugin runs.

XML files are reported and marked differently due to Tika recognition described 
in RAT-502.



> Errors in license detection on RAT source tree itself, GPL is marked in 
> module apache-rat-core
> ----------------------------------------------------------------------------------------------
>
>                 Key: RAT-501
>                 URL: https://issues.apache.org/jira/browse/RAT-501
>             Project: Apache Rat
>          Issue Type: Bug
>    Affects Versions: 0.17
>            Reporter: Philipp Ottlinger
>            Assignee: Philipp Ottlinger
>            Priority: Major
>             Fix For: 1.0.0
>
>
> After pushing the release I wanted to make RAT dog food itself .... and ran 
> into minor problems on the existing source tree.
> h2. Core submodule
> Recognizes GPL-licenses albeit ASF license header is added:
> ! /src/main/resources/org/apache/rat/default.xml
>   S         application/xml    UTF-8
>     AL       AL1.1         Apache License 1.1
>     AL       AL2.0         Apache License 2.0
>     BSD-3    DOJO          DOJO License
>     CDDL1    CDDL1         COMMON DEVELOPMENT AND DISTRIBUTION LICENSE 
> Version 1.0
>     CDDL1    ILLUMOS       ILLUMOS CDDL1 Derived license
>     GPL      GPL1          GNU General Public License V1.0 (Unapproved)
>     GPL      GPL2          GNU General Public License V2.0 (Unapproved)
>     GPL      GPL3          GNU General Public License V3.0 (Unapproved)
>     MIT      MIT           The MIT License
>     W3C      W3C           W3C Software Copyright
>     W3CD     W3CD          W3C Document Copyright
>   
> ! /src/main/resources/org/apache/rat/example-configuration.xml
>   S         application/xml    UTF-8
>     AL       AL1.1         Apache License 1.1
>     AL       AL2.0         Apache License 2.0
>     BSD-3    DOJO          DOJO License
>     CDDL1    CDDL1         COMMON DEVELOPMENT AND DISTRIBUTION LICENSE 
> Version 1.0
>     CDDL1    ILLUMOS       ILLUMOS CDDL1 Derived license
>     GPL      GPL1          GNU General Public License V1.0 (Unapproved)
>     GPL      GPL2          GNU General Public License V2.0 (Unapproved)
>     GPL      GPL3          GNU General Public License V3.0 (Unapproved)
>     MIT      MIT           The MIT License
>     W3C      W3C           W3C Software Copyright
>     W3CD     W3CD          W3C Document Copyright
> ! /src/test/java/org/apache/rat/analysis/license/GPLLicenseTest.java
>   S         text/x-java-source    ISO-8859-1
>     AL       AL2.0         Apache License 2.0
>     GPL      GPL1          GNU General Public License V1.0 (Unapproved)
>     GPL      GPL2          GNU General Public License V2.0 (Unapproved)
>     GPL      GPL3          GNU General Public License V3.0 (Unapproved)
> ! /src/test/java/org/apache/rat/ReporterOptionsProvider.java
>   S         text/x-java-source    ISO-8859-1
>     AL       AL2.0         Apache License 2.0
>     BSD-3    BSD-3         BSD 3 clause
>     CDDL1    ILLUMOS       ILLUMOS CDDL1 Derived license
>     GPL      GPL1          GNU General Public License V1.0 (Unapproved)
> h2. Possible hints of configuration errors in site build
> [WARNING] Basedir is : /home/me/creadur-rat/apache-rat
> [INFO] Excluding patterns: src/site/examples/**, src/site/apt/*.txt
> [INFO] Excluding MAVEN collection.
> [INFO] Excluding ECLIPSE collection.
> [INFO] Excluding IDEA collection.
> [INFO] Processing exclude file from STANDARD_SCMS.
> [INFO] Excluding STANDARD_SCMS collection.
> [INFO] Excluding MISC collection.
> [INFO] Excluding HIDDEN_DIR collection.
> [WARNING] Duplicate LicenseFamily category: AL    (action: IGNORE)
> [WARNING] Duplicate LicenseFamily category: BSD-3 (action: IGNORE)
> [WARNING] Duplicate LicenseFamily category: CDDL1 (action: IGNORE)
> [WARNING] Duplicate LicenseFamily category: GPL   (action: IGNORE)
> [WARNING] Duplicate LicenseFamily category: MIT   (action: IGNORE)
> [WARNING] Duplicate LicenseFamily category: OASIS (action: IGNORE)
> [WARNING] Duplicate LicenseFamily category: W3C   (action: IGNORE)
> [WARNING] Duplicate LicenseFamily category: W3CD  (action: IGNORE)
> [WARNING] Duplicate License Apache License 1.0 (AL1.0) of type AL    (action: 
> IGNORE)
> [WARNING] Duplicate License Apache License 1.1 (AL1.1) of type AL    (action: 
> IGNORE)
> [WARNING] Duplicate License Apache License 2.0 (AL2.0) of type AL    (action: 
> IGNORE)
> [WARNING] Duplicate License BSD 3 clause (BSD-3) of type BSD-3 (action: 
> IGNORE)
> [WARNING] Duplicate License DOJO License (DOJO) of type BSD-3 (action: IGNORE)
> [WARNING] Duplicate License The Telemanagement Forum License (TMF) of type 
> BSD-3 (action: IGNORE)
> [WARNING] Duplicate License COMMON DEVELOPMENT AND DISTRIBUTION LICENSE 
> Version 1.0 (CDDL1) of type CDDL1 (action: IGNORE)
> [WARNING] Duplicate License ILLUMOS CDDL1 Derived license (ILLUMOS) of type 
> CDDL1 (action: IGNORE)
> [WARNING] Duplicate License GNU General Public License V1.0 (GPL1) of type 
> GPL   (action: IGNORE)
> [WARNING] Duplicate License GNU General Public License V2.0 (GPL2) of type 
> GPL   (action: IGNORE)
> [WARNING] Duplicate License GNU General Public License V3.0 (GPL3) of type 
> GPL   (action: IGNORE)
> [WARNING] Duplicate License The MIT License (MIT) of type MIT   (action: 
> IGNORE)
> [WARNING] Duplicate License OASIS Open License (OASIS) of type OASIS (action: 
> IGNORE)
> [WARNING] Duplicate License W3C Software Copyright (W3C) of type W3C   
> (action: IGNORE)
> [WARNING] Duplicate License W3C Document Copyright (W3CD) of type W3CD  
> (action: IGNORE)
> [INFO] Excluding MISC collection.
> [INFO] Excluding HIDDEN_DIR collection.
> [INFO] Generating "SpotBugs" report             --- 
> spotbugs-maven-plugin:4.8.6.6:spotbugs
> [INFO] Generating "Project Information" report  --- 
> maven-site-plugin:3.21.0:project-info
> [INFO] Generating "Generated Reports" report    --- 
> maven-site-plugin:3.21.0:project-reports
> maybe that's the reason for the problems.
> h2. Workaround / commit b421d0894f46ad6317d9f4af63a7f1680fcc886b
> In order to not break the build the following files are ignored (as they are 
> parsed as GPL):
> * default.xml
> * example-configuration.xml
> * ReporterOptionsProvider.java
> * GPLLicenseTest.java
> h2. Solution
> As RAT0.17 marks GPL as unapproved by default (=breaking change to earlier 
> releases) the plugin marks any files with GPL-contents as UNAPPROVED,
> thus:
> * ReporterOptionsProvider.java
> * GPLLicenseTest.java
> are marked as unapproved during plugin runs.
> XML files are reported and marked differently due to Tika recognition 
> described in RAT-502.
> Augment eclipse default excludes to include during analysis:
> * "**/.externalToolBuilders/**" and
> *  "**/bin/**"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to