snazy commented on PR #568:
URL: https://github.com/apache/creadur-rat/pull/568#issuecomment-3476286833

   I _think_ this PR is pretty close. It just does its thing and the 
non-generated code isn't overly complex ("just" Gradle-ish), thanks to the 
generated property/configuration code.
   
   Most of the TODOs are done now:
   * tests
   * Maven build integration (no CI workflow change necessary)
   * The plugin's configured in "the Gradle way" (using it's specialized 
`Property` types)
   
   This PR also depends on the Java "minimum" requirement.
   
   Open TODOs:
   * Fix Maven 'verify' - the added `smoketest` fails
   * use the RAT project's code style (and not the Google one).
   * Documentation (probably worth to tackle that separately)
   
   I left the HTML report "broken" for now. Maybe worth to spill that work out 
to a separate PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to