ottlinger commented on code in PR #576:
URL: https://github.com/apache/creadur-rat/pull/576#discussion_r2513950931
##########
apache-rat-core/src/test/java/org/apache/rat/ReporterOptionsProvider.java:
##########
@@ -798,37 +760,37 @@ protected void licensesApprovedTest() {
new String[]{"GPL1"});
}
- @OptionCollectionTest.TestFunction
- protected void scanHiddenDirectoriesTest() {
- Option option = Arg.INCLUDE_STD.find("scan-hidden-directories");
- Pair<Option, String[]> arg1 = ImmutablePair.of(option, null);
-
- try {
- configureSourceDir(option);
-
- writeFile("apl.txt", "SPDX-License-Identifier: Apache-2.0");
-
- File hiddenDir = new File(sourceDir, ".hiddendir");
- FileUtils.mkDir(hiddenDir);
- FileUtils.writeFile(hiddenDir, "gpl.txt",
Collections.singletonList("SPDX-License-Identifier: GPL-1.0-only"));
-
- ReportConfiguration config = generateConfig();
- Reporter reporter = new Reporter(config);
- ClaimStatistic claimStatistic = reporter.execute();
-
assertThat(claimStatistic.getCounter(ClaimStatistic.Counter.STANDARDS)).isEqualTo(1);
-
assertThat(claimStatistic.getCounter(ClaimStatistic.Counter.APPROVED)).isEqualTo(1);
-
assertThat(claimStatistic.getCounter(ClaimStatistic.Counter.UNAPPROVED)).isEqualTo(0);
-
- config = generateConfig(arg1);
- reporter = new Reporter(config);
- claimStatistic = reporter.execute();
-
assertThat(claimStatistic.getCounter(ClaimStatistic.Counter.STANDARDS)).isEqualTo(2);
-
assertThat(claimStatistic.getCounter(ClaimStatistic.Counter.APPROVED)).isEqualTo(1);
-
assertThat(claimStatistic.getCounter(ClaimStatistic.Counter.UNAPPROVED)).isEqualTo(1);
- } catch (IOException | RatException e) {
- fail(e.getMessage(), e);
- }
- }
+// @OptionCollectionTest.TestFunction
Review Comment:
Could we add a TODO here in order to make it easier to find the spot that
needs more work ;) Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
