ottlinger commented on code in PR #583:
URL: https://github.com/apache/creadur-rat/pull/583#discussion_r2513995125
##########
apache-rat-plugin/src/test/resources/unit/it3/pom.xml:
##########
@@ -27,8 +27,10 @@
<artifactId>apache-rat-plugin</artifactId>
<version>@pom.version@</version>
<configuration>
- <numUnapprovedLicenses>1</numUnapprovedLicenses>
- <addLicenseHeaders>true</addLicenseHeaders>
+ <counterMin>Unapproved:1</counterMin>
+ <editLicense>true</editLicense>
+<!-- <numUnapprovedLicenses>1</numUnapprovedLicenses>-->
Review Comment:
This could be a helpful entry into the migration guide - e.g.
if your config was foo now it has to become bar, but I fear it will be to
cumbersome to read too many examples. Maybe we should add a reference to the
Itests instead to see for examples of the new configuration?
This is why I started
https://github.com/ottlinger/creadur-rat-examples
a while ago to have running examples for questions that arose on the mailing
list or in jira tickets.
##########
apache-rat-plugin/src/test/resources/unit/it3/pom.xml:
##########
@@ -27,8 +27,10 @@
<artifactId>apache-rat-plugin</artifactId>
<version>@pom.version@</version>
<configuration>
- <numUnapprovedLicenses>1</numUnapprovedLicenses>
- <addLicenseHeaders>true</addLicenseHeaders>
+ <counterMin>Unapproved:1</counterMin>
+ <editLicense>true</editLicense>
+<!-- <numUnapprovedLicenses>1</numUnapprovedLicenses>-->
+<!-- <addLicenseHeaders>true</addLicenseHeaders>-->
Review Comment:
Let's remove the old options completely to not confuse too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
