Claudenw commented on code in PR #662: URL: https://github.com/apache/creadur-rat/pull/662#discussion_r3279376779
########## apache-rat-tasks/src/test/java/org/apache/rat/anttasks/ReportOptionTest.java: ########## @@ -53,9 +55,11 @@ /** * Tests to ensure the option setting works correctly. */ +@DisabledIf(value = "isRunningOnGitHubActionOrLinux", disabledReason = "RAT-555, RAT-475") Review Comment: `or linux`? Should this not be `and linux`? or `with linux` so it is clear that it is only disabled on github running linux. Also, I think the implementation of `isRunningOnGitHubActionOrLinux` is incorrect. as it should only return true with linux on github. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
