Claudenw commented on code in PR #637:
URL: https://github.com/apache/creadur-rat/pull/637#discussion_r3302013372
##########
apache-rat-tools/src/main/java/org/apache/rat/tools/AntDocumentation.java:
##########
@@ -79,13 +77,13 @@ public static void main(final String[] args) {
new AntDocumentation(outputDir).execute();
}
- private AntDocumentation(final File outputDir) {
+ /* Visible for testing */
Review Comment:
As I recall, this class and methods will be used in the Ant UI package.
I wouldn't worry too much about tools as it goes away at the end of this
trasformation.
In the end we will have the following modules
- core: (the core functionality)
- core test: test code from core packaged with dependencies to make it
easier for UI modules. Basically a maven module that points to core
`/src/test` for its `/src/main`. Jars built like this include dependencies so
that when included as test libraries the transitive dependencies are present.
- CLI: the current command line interface
- ANT: the ANT interface and components from tools that are used for it.
- Maven: the Maven interface and the components from tools that are used for
it.
- packaging: -- Not sure about this one, but I think that it just puts
outputs from the above modules into release (as in upload to sonatype or github
release style) packages and deploys them.
The UI modules CLI, ANT, and Maven will have multiple sub modules.
Something like
UI module pom
- tools: Tooling from current tool module + additional bits.
- main: The actual code that is released. Module should build the
packaging necessary to use the UI as a stand alone unit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
