ottlinger commented on code in PR #674:
URL: https://github.com/apache/creadur-rat/pull/674#discussion_r3465708398
##########
apache-rat-core/src/test/java/org/apache/rat/test/AbstractConfigurationOptionsProvider.java:
##########
@@ -156,7 +161,8 @@ protected AbstractConfigurationOptionsProvider(final
Collection<String> unsuppor
private void execExcludeTest(final Option option, final String[] args) {
String[] notExcluded = {"notbaz", "well._afile"};
String[] excluded = {"some.foo", "B.bar", "justbaz"};
- try {
+
+ assertDoesNotThrow(() -> {
Review Comment:
@Claudenw I honestly did not really get why there were these try/catch
before .... if the test fails an exception should be logged properly. Not sure
if all this assertDoesNotThrow() makes sense at all, but it makes logging an
exception more explicit. Any particular reason for these constructs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
