ctubbsii commented on code in PR #698:
URL: https://github.com/apache/creadur-rat/pull/698#discussion_r3561651355
##########
pom.xml:
##########
@@ -45,27 +45,25 @@ agnostic home for software distribution comprehension and
audit tools.
<properties>
<sonar.organization>apache</sonar.organization>
<sonar.host.url>https://sonarcloud.io</sonar.host.url>
- <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<!-- taken from
https://maven.apache.org/guides/mini/guide-reproducible-builds.html, updated by
maven-release-plugin -->
<project.build.outputTimestamp>2026-03-11T23:25:45Z</project.build.outputTimestamp>
<ant.version>1.10.17</ant.version>
<assertj.version>4.0.0-M1</assertj.version>
+ <!-- this is the target Java version that this project supports at runtime
-->
<javaVersion>17</javaVersion>
<tika.version>3.3.1</tika.version>
<mockito.version>5.23.0</mockito.version>
- <maven.compiler.source>${javaVersion}</maven.compiler.source>
- <maven.compiler.target>${javaVersion}</maven.compiler.target>
<!-- This is the version of Maven required to use the RAT Maven Plugin -->
<mavenMinVersion>3.9</mavenMinVersion>
- <mavenVersion>3.9.16</mavenVersion>
+ <!-- minimal versions to build this projects, enforced in parent POM by
enforcer plugin -->
+ <minimalJavaBuildVersion>17</minimalJavaBuildVersion>
+ <minimalMavenBuildVersion>3.9.16</minimalMavenBuildVersion>
<creadur.jira.id>RAT</creadur.jira.id>
<velocity.core.version>2.4.1</velocity.core.version>
<velocity.tools.version>3.1</velocity.tools.version>
<!-- maven plugin versions -->
<mavenPluginTestingVersion>3.5.1</mavenPluginTestingVersion>
- <mavenPluginPluginVersion>3.15.2</mavenPluginPluginVersion>
<mavenChangesVersion>3.0.0-M3</mavenChangesVersion>
- <mavenJavadocPluginVersion>3.12.0</mavenJavadocPluginVersion>
Review Comment:
These properties were previously necessary to use newer versions of these
plugins to override the versions defined in the ASF parent POM. Since then, the
parent POM was updated, and uses these newer versions already, so these are no
longer needed. New patches can override the versions again if it ever becomes
necessary to override the version from the parent POM again, but right now,
that is not necessary. However, if it does become necessary, the parent POM
makes it easier to override the version by managing the plugin versions with
properties, so you don't need to make your own properties and pluginManagment
entries to merely override a version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
