Claudenw commented on code in PR #697:
URL: https://github.com/apache/creadur-rat/pull/697#discussion_r3594418727
##########
apache-rat-core/src/main/java/org/apache/rat/config/exclusion/ExclusionProcessor.java:
##########
@@ -337,4 +395,91 @@ private void extractPaths(final MatcherSet.Builder
matcherBuilder) {
}
}
+ /**
+ * Serializes and deserializes the ExclusionProcessor to XML document
+ */
+ public class Serde {
Review Comment:
Wait. The outer class in the case above is ExclusionProcessor. It has a
method `public Serde getSerde()` which returns an instance of
`ExlcusionProcessor.Serde`. So we change the name of
`ExclusionProcessor.Serde` to `ExclusiongProcessor.SerDes` and the method
signature to `public SerDes getSerdes()`?
There should be no `SerDes.serDes()`. the SerDes should implement a
`serializer()` and a `deserializer.()` method.
What am I missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
