gnodet commented on code in PR #704:
URL: https://github.com/apache/creadur-rat/pull/704#discussion_r3672132492
##########
apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:
##########
@@ -101,10 +125,10 @@ public Match create(final String spdxId) {
if (StringUtils.isBlank(spdxId)) {
throw new ConfigurationException("'SPDX' type matcher requires a
name");
}
- Match matcher = MATCHER_MAP.get(spdxId);
+ Match matcher = matcherMap.get(spdxId);
if (matcher == null) {
matcher = new Match(spdxId);
- MATCHER_MAP.put(spdxId, matcher);
+ matcherMap.put(spdxId, matcher);
Review Comment:
Done — replaced the get/null-check/put block with
`matcherMap.computeIfAbsent(spdxId, Match::new)`.
##########
src/changes/changes.xml:
##########
@@ -68,6 +68,9 @@ in order to be properly linked in site reports.
</release>
-->
<release version="1.0.0-SNAPSHOT" date="xxxx-yy-zz" description="Current
SNAPSHOT - release to be done">
+ <action issue="RAT-573" type="add" dev="pottlinger" due-to="Guillaume
Nodet">
+ Make DefaultLog and DeprecationReporter thread-safe in order to allow
parallel Maven builds.
Review Comment:
Done — updated to "Make RAT safe for parallel builds".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
