Claudenw commented on code in PR #655: URL: https://github.com/apache/creadur-rat/pull/655#discussion_r4173488327
########## apache-rat-core/src/main/java/org/apache/rat/commandline/Converters.java: ########## Review Comment: Long reasoning so from the start. 1. the Option class is immutable. 2. FileConverter is used for Option that expect file names so that they return Files. 3. an Arg contains one or more Options. When file based Options are created the FileConverter must be declared. 4. Args are an enumeration and so constructed very early. 5. The working directory is not known until after the Arg are created. In fact the working directory is not known until after the arguments are parsed and may be modified again by the UI. I think that there may be future cases where we want to change the working directory during operation. But I don't have an example yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
