rmannibucau commented on code in PR #746:
URL: https://github.com/apache/creadur-rat/pull/746#discussion_r4370300344


##########
apache-rat-core/src/main/java/org/apache/rat/config/exclusion/fileprocessors/GitIgnoreBuilder.java:
##########
@@ -147,16 +147,23 @@ protected Optional<String> modifyEntry(final 
Consumer<MatcherSet> matcherSetCons
 
     /**
      * The global gitignore file to process, based on the
-     * {@link EnvVar#RAT_NO_GIT_GLOBAL_IGNORE},
-     * {@link EnvVar#XDG_CONFIG_HOME} and
-     * {@link EnvVar#HOME} environment
+     * {@link EnvVar#RAT_NO_GIT_GLOBAL_IGNORE}, the git configuration
+     * ({@code core.excludesFile} including {@code [include] path} directives)
+     * and the {@link EnvVar#XDG_CONFIG_HOME} and {@link EnvVar#HOME} 
environment
      * variables.
      */
     protected Optional<File> globalGitIgnore() {
         if (EnvVar.RAT_NO_GIT_GLOBAL_IGNORE.isSet()) {
             return Optional.empty();
         }
 
+        Optional<File> fromConfig = new GitConfig().coreExcludesFile();

Review Comment:
   have to admit i never used excludesFile in a nested gitignore but my 
understanding of the doc - didnt take time to check git sources but can next 
week if it helps - is that it is not supported, do you get it differently?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to