[
https://issues.apache.org/jira/browse/RAT-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18145194#comment-18145194
]
ASF subversion and git services commented on RAT-578:
-----------------------------------------------------
Commit 5233b7b855dfc7a03c2bbcc78536075b66530d5e in creadur-rat's branch
refs/heads/fix/RAT-592 from Romain Manni-Bucau
[ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=5233b7b85 ]
RAT-578: Address review comments on RAT_GIT_GLOBAL_IGNORE and USERPROFILE
Rename the EnvVar.USERPROFILE constant to USER_PROFILE for naming consistency
with the other constants, while keeping the actual environment variable read
as USERPROFILE (the canonical Windows name) via a getValue() override on the
enum constant.
Convert the RAT_GIT_GLOBAL_IGNORE 'on'/'off' keywords to a tri-state value
documented explicitly as not a plain boolean: 'false' disables the global
git ignore, 'true' (or unset) resolves it from the git configuration, and
any other value is treated as an explicit global git ignore path. This
matches the existing path-mode design while aligning the boolean keyword
spelling with the rest of the RAT configuration options.
Update the EnvVar, GitIgnoreBuilder and StandardCollection javadoc to use
well-formed closed block HTML so it builds cleanly across JDK 17/21/25.
changes.xml: mark the RAT_GIT_GLOBAL_IGNORE entry as type=add with
due-to=Romain Manni-Bucau and reword it for the tri-state semantics.
Switch the CI workflow from RAT_NO_GIT_GLOBAL_IGNORE to the new
RAT_GIT_GLOBAL_IGNORE=false for reproducible audits.
GitIgnoreBuilderTest: use 'false'/'true' (with case-insensitive checks) and
keep the explicit-path coverage.
Full apache-rat-core build passes: 1155 tests, checkstyle and javadoc clean.
> RAT doesn't consider excludesfile in ~/.gitconfig so it fails unexpectedly
> when merging gitignores and explicit ignores
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: RAT-578
> URL: https://issues.apache.org/jira/browse/RAT-578
> Project: Apache RAT
> Issue Type: Improvement
> Components: scan
> Affects Versions: 0.18
> Reporter: Romain Manni-Bucau
> Priority: Major
> Fix For: 0.19
>
>
> Pls see discussion in the PR!
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)