[ 
https://issues.apache.org/jira/browse/CRUNCH-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13596329#comment-13596329
 ] 

Gabriel Reid commented on CRUNCH-179:
-------------------------------------

Ok, as you're the person with that use case, you're probably the best placed to 
decide if the hassle of creating a list of PCollections instead of using 
varargs is worth it to not have to deal with the compiler warnings :-)

Actually, come to think of it, if we add a version that accepts a List, 
Arrays.asList or Lists.newArrayList will probably be the most common way of 
constructing that list, and they'll just result in the same compiler warning, 
so I guess we'd best leave the varargs version alone.
                
> Add a properly typed union() method to PCollection and PTable
> -------------------------------------------------------------
>
>                 Key: CRUNCH-179
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-179
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Josh Wills
>            Assignee: Josh Wills
>            Priority: Minor
>         Attachments: CRUNCH-179.patch
>
>
> I find myself slightly (albeit persistently) irritated by the warnings that 
> come up in Eclipse as a function of using varargs for the union method on 
> PCollection and PTable, so I wrote a union() method that takes a single 
> argument and delegates to the regular union method. No functional change, 
> just cleans up an irritating warning in my client code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to