[
https://issues.apache.org/jira/browse/CRUNCH-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600923#comment-13600923
]
Matthias Friedrich commented on CRUNCH-178:
-------------------------------------------
Looks good from an API point of view. The only trivial issue I found is that
the random seed should probably be a primitive in the API. Some even more
trivial things while we're at it: You could copy and paste some javadoc so that
the Sample class is fully documented and quote the "<" characters. Sorry for
nitpicking ;-)
> Add library functions for performing distributed reservoir sampling
> -------------------------------------------------------------------
>
> Key: CRUNCH-178
> URL: https://issues.apache.org/jira/browse/CRUNCH-178
> Project: Crunch
> Issue Type: Improvement
> Components: MapReduce Patterns
> Reporter: Josh Wills
> Attachments: CRUNCH-178b.patch, CRUNCH-178c.patch, CRUNCH-178.patch
>
>
> For a project I've been working on, I wrote up some Crunch functions for
> performing reservoir sampling and weighted reservoir sampling that I think
> would be useful enough to put in lib.* Here's the paper that I used as a
> reference for the implementations I wrote:
> http://arxiv.org/pdf/1012.0256.pdf
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
