[
https://issues.apache.org/jira/browse/CRUNCH-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791878#comment-13791878
]
Josh Wills commented on CRUNCH-278:
-----------------------------------
Roger on the additional docs for ReadableSourceBundle.
Your assessment of where I was thinking of taking it is correct. My thought was
that doing it might require an API change to ReadableSourceBundle.read() to
take a TaskInputOutputContext (or something similar) so that the DoFns that
were contained in the ReadableSourceBundle could have a proper
setContext/initialize performed before they were called: what do you think of
having the more complex API available now, even if we don't actually set it up
to use the DoFns (which I agree w/you on: it will have some additional
complexity involved to make it work correctly.)
> Improvements to MapsideJoin code
> --------------------------------
>
> Key: CRUNCH-278
> URL: https://issues.apache.org/jira/browse/CRUNCH-278
> Project: Crunch
> Issue Type: Bug
> Components: Core, MapReduce Patterns
> Reporter: Josh Wills
> Assignee: Josh Wills
> Attachments: CRUNCH-278.patch
>
>
> The fact that we have special-case code in the MapsideJoinStrategy for the
> in-memory and MR-based Pipeline instances has always bugged me, so I set out
> to eliminate the distinction between the two impls by creating a new
> interface, ReadableSourceBundle<T>, that encapsulates the MR and in-memory
> specific logic for doing mapside joins in order to remove the special-case
> code in MapsideJoinStrategy and hopefully make other implementations that use
> our mapside-join patterns much easier to test.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
