[
https://issues.apache.org/jira/browse/CRUNCH-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826072#comment-13826072
]
Micah Whitacre commented on CRUNCH-293:
---------------------------------------
The changes look good to me. The one part I'm still trying to think through is
if configuring the custom factory on a global scope vs per source is
sufficient. Generally most teams will have a single custom implementation of a
custom DataReader but there might be cases where they need to pull sources from
multiple teams and need a custom reader.
> Injection of reader into AvroRecordReader
> -----------------------------------------
>
> Key: CRUNCH-293
> URL: https://issues.apache.org/jira/browse/CRUNCH-293
> Project: Crunch
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Micah Whitacre
> Assignee: Micah Whitacre
> Attachments: CRUNCH-293.patch, CRUNCH-293_v2.patch
>
>
> With CRUNCH-243, I wanted to support injecting custom readers to handle the
> cases like passivity between Avro Schema. The changes made however were not
> complete as we also need to be able to inject a reader into the
> AvroRecordReader which constructs its own SpecificDatumReader.
> We could create a SpecificDataFactory which emulates the ReflectDataFactory.
> Or simplify to a single DataFactory which will create either
> Reflect/Specific/Generic. Thoughts?
--
This message was sent by Atlassian JIRA
(v6.1#6144)
