[ 
https://issues.apache.org/jira/browse/CRUNCH-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876536#comment-13876536
 ] 

Josh Wills commented on CRUNCH-323:
-----------------------------------

LGTM.

Re: it's, I'm still kicking myself for the reservorSample error in CRUNCH-324; 
I was a spelling bee champion in the 8th grade. ;-)

> Add a section on getDetachedValue to the user guide
> ---------------------------------------------------
>
>                 Key: CRUNCH-323
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-323
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Site
>            Reporter: Gabriel Reid
>            Assignee: Gabriel Reid
>            Priority: Minor
>         Attachments: getDetachedValue.1.patch, getDetachedValue.patch
>
>
> The use of the PType#getDetachedValue is a useful bit of information, and a 
> common gotcha when working with Crunch and MapReduce. A section explaining 
> how to deal with retaining references within a DoFn should be added to the 
> user guide.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to