[
https://issues.apache.org/jira/browse/CRUNCH-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabriel Reid updated CRUNCH-216:
--------------------------------
Attachment: CRUNCH-216.patch
Patch that provides static factory methods for creating MapsideJoinStrategy
instances that expect the left-most table to be the smaller of the tables being
joined, and deprecates the public constructors and factory methods for creating
instances that expect the right-most table to be the smaller table.
The factory methods for legacy instance creation are called
createLegacyMapsideJoinStrategy, although I'm actually wondering if they're
even needed at all, i.e. maybe it would be better to just deprecate the
constructor and not add deprecated legacy factory methods.
> Transpose arguments in MapsideJoinStrategy.join
> -----------------------------------------------
>
> Key: CRUNCH-216
> URL: https://issues.apache.org/jira/browse/CRUNCH-216
> Project: Crunch
> Issue Type: Improvement
> Reporter: Gabriel Reid
> Attachments: CRUNCH-216.patch
>
>
> The MapsideJoinStrategy currently specifies that the smaller table in the
> join (i.e. the table to be replicated and loaded in memory) should be on the
> right-hand side of the join.
> This is the opposite of what is done in all other join strategies, making it
> impossible to just switch out another join strategy for a
> MapsideJoinStrategy. The MapsideJoinStrategy could be brought in line with
> the other JoinStrategies to expect the smaller of two tables to be provided
> as the left-side table.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
