[ 
https://issues.apache.org/jira/browse/CRUNCH-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009929#comment-14009929
 ] 

Josh Wills commented on CRUNCH-401:
-----------------------------------

So I think we have an issue with the deprecation of this parameter, b/c we 
haven't deprecated the similar parameters for crunch.specificfactory and 
crunch.genericfactory. Don't we want people to be able to override the 
ReadWriteFactory when they have to? If so, it seems like the param should be 
non-deprecated somewhere, even if that reference to it in 
o.a.c.types.avros.Avros is deprecated.

> Make it possible to override AvroMode.REFLECTs ReaderWriterFactory
> ------------------------------------------------------------------
>
>                 Key: CRUNCH-401
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-401
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core
>            Reporter: Josh Wills
>            Assignee: Josh Wills
>         Attachments: CRUNCH-401.patch
>
>
> After struggling with some Scrunch issues w/respect to Avro reflection, I 
> discovered that it wasn't possible for me to override the Java 
> ReflectDataFactory that is associated with AvroMode.REFLECT like I can for 
> AvroMode.SPECIFIC and AvroMode.GENERIC.
> I put together a patch that enables us to overwrite the Reader/Writer 
> behavior associated with AvroMode.REFLECT globally, and demonstrated how to 
> use this behavior to fix a Scrunch bug where Scala's byte array class wasn't 
> getting properly serialized on reflection in Scrunch.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to