[
https://issues.apache.org/jira/browse/CRUNCH-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034889#comment-14034889
]
Gabriel Reid commented on CRUNCH-418:
-------------------------------------
This looks good [~aj987], thanks!
Using the end of the pipeline name instead of the start was intentional, as the
pipeline name is a fully-qualified class name by default, so my assumption was
that cutting off the start of the string (i.e. which would typically be part of
the package name) would be better than cutting off the end. That being said, it
was a pretty arbitrary decision, and no matter what happens, cutting off part
of the name is throwing out information so it'll be "wrong" at least some of
the time, so I'm definitely fine with cutting out the end instead of the start
in what is hopefully a very rare edge case.
Swallowing the {{URISyntaxException}} was a similarly arbitrary decision, but I
think you're right to handle any exception situations in the same way.
I'll commit your patch later on today. I've created CRUNCH-423 to document this
functionality in the user guide once it's in a released version of Crunch.
Thanks again for the reviews and improvements!
> Auto-logging Plan
> -----------------
>
> Key: CRUNCH-418
> URL: https://issues.apache.org/jira/browse/CRUNCH-418
> Project: Crunch
> Issue Type: Wish
> Reporter: Allan Shoup
> Assignee: Gabriel Reid
> Priority: Minor
> Attachments: CRUNCH-418.2.patch, CRUNCH-418.3.patch, CRUNCH-418.patch
>
>
> It would be handy if Crunch was capable of logging out the plan DOT diagram
> automatically whenever the pipeline was run.
> By default I would log the plan at a level below INFO - probably at DEBUG.
> Additionally, configuration could be provided to specify the level that the
> plan should be logged at (for example if you always wanted it logged at INFO
> level, or if you wanted to disable logging the plan altogether).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
