[ https://issues.apache.org/jira/browse/CRUNCH-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043829#comment-14043829 ]
Brandon Inman commented on CRUNCH-414: -------------------------------------- Instead of a threshold, could you use endOfFile? Psuedocode- {code} } while (currentlyInQuotes && !endOfFile); if(endOfFile && currentlyInQuotes) { throw new IOException("File ended inside of an escaped region"); } {code} > The CSV file source needs to be a little more robust when handling multi-line > CSV files > --------------------------------------------------------------------------------------- > > Key: CRUNCH-414 > URL: https://issues.apache.org/jira/browse/CRUNCH-414 > Project: Crunch > Issue Type: Improvement > Components: Core > Affects Versions: 0.8.3 > Reporter: mac champion > Assignee: mac champion > Priority: Minor > Labels: csv, csvparser > Fix For: 0.8.4 > > Original Estimate: 336h > Remaining Estimate: 336h > > Brandon Inman recently reported an undesriable behavior in the CSV file > source group of files. Currently, the CSVLineReader, if reading a malformed > CSV file, can enter a state where it is perpetually waiting for an end-quote > character. As he put it, "Malformed files are malformed files and should > probably fail in some regard, but a hang is obviously undesirable." > Essentially, the CSVLineReader needs to be tweaked in such a way that an > informative exception is thrown after some threshold is reached, instead of > basically just hanging. -- This message was sent by Atlassian JIRA (v6.2#6252)