[
https://issues.apache.org/jira/browse/CRUNCH-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184449#comment-14184449
]
Gabriel Reid commented on CRUNCH-476:
-------------------------------------
Definitely looks good, and a big improvement switching to slf4j. I think there
are still some things that can be improved in terms of logging (i.e. using
format strings in logging calls) with slf4j, but no need to necessarily deal
with that as part of this ticket.
One small point: I think that the commons-logging dependency can be removed
from the root pom now right?
Also, interesting commit message :-)
> Logging API Consistency
> -----------------------
>
> Key: CRUNCH-476
> URL: https://issues.apache.org/jira/browse/CRUNCH-476
> Project: Crunch
> Issue Type: Improvement
> Components: Core
> Reporter: Micah Whitacre
> Assignee: Micah Whitacre
> Attachments: CRUNCH-476.patch
>
>
> Poking around the code I noticed that HBase uses log4j while most of
> crunch-core, crunch-spark use commons-logging. If the variation is justified
> that is fine but for consumer wanting to consistently configure logging for
> Crunch jobs it would be nice to use a consistent API and then let them
> configure it one way.
> Our options are possibly to converge on one implementation or move to
> something like slf4j and allow consumers to swap out the impl at assembly
> time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
