[ https://issues.apache.org/jira/browse/CRUNCH-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206638#comment-14206638 ]
Josh Wills commented on CRUNCH-480: ----------------------------------- [~gabriel.reid] agree with your analysis of the Builder issue, that seems tough to overcome in the current impl. Maybe we deprecate the builder method that allows you to use a Schema directly and point folks at the one that uses the Specific Class or the constructor? Open to ideas here, I'm not sure what the best approach is. [~tomwhite] is there a Version object/method in Parquet I can use to know which version I'm running so I can set the DISABLE_COMBINE_FILE conditionally? > AvroParquetFileSource doesn't properly configure user-supplied read schema > -------------------------------------------------------------------------- > > Key: CRUNCH-480 > URL: https://issues.apache.org/jira/browse/CRUNCH-480 > Project: Crunch > Issue Type: Bug > Components: IO > Affects Versions: 0.10.0 > Reporter: E. Sammer > Assignee: Gabriel Reid > Priority: Blocker > Attachments: CRUNCH-480.1.patch, CRUNCH-480.patch > > > It seems like AvroParquetFileSource doesn't properly set the configuration > param required to use a user-supplied read schema that differs from the > schema in the file. > Deep in the guts of Parquet (InternalParquetReader#initialize()), I found > this: > {code} > this.recordConverter = readSupport.prepareForRead( > configuration, extraMetadata, fileSchema, > new ReadSupport.ReadContext(requestedSchema, readSupportMetadata)); > {code} > Later, in Parquet's AvroReadSupport#prepareForRead(), it appears to ignore > the supplied requestedSchema and, instead, looks for the key avro.read.schema > in the readSupportMetadata map. This is seriously kookie code in Parquet > (i.e. wrong), but because Crunch doesn't supply readSupportMetadata, we can > never properly supply a read schema. Boooo hisssss. -- This message was sent by Atlassian JIRA (v6.3.4#6332)