[ https://issues.apache.org/jira/browse/CRUNCH-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335062#comment-14335062 ]
Gabriel Reid commented on CRUNCH-501: ------------------------------------- [~aj987] Does the addition of {{DoFns.detach}} cover the possible requirement to make the PType available within all DoFns? Or perhaps the addition of some other convenience methods to do stuff like this? This would get around having to worry about shared state in generic singleton DoFns, and it might be a more user-friendly fit for this stuff (or maybe not). > Object reuse issue in combineValues(Aggregator) > ----------------------------------------------- > > Key: CRUNCH-501 > URL: https://issues.apache.org/jira/browse/CRUNCH-501 > Project: Crunch > Issue Type: Bug > Reporter: Brandon Davis > Attachments: CRUNCH-501.patch > > > I'm trying to use combineValues on a PGroupedTable. I am using > Aggregators.FIRST_N. If I have 20 keys in my PGroupedTable, then I only get > 20 distinct values because the AggregatorCombineFn and FirstNAggregator don't > detach the values from the incoming iterator. -- This message was sent by Atlassian JIRA (v6.3.4#6332)