[ 
https://issues.apache.org/jira/browse/CRUNCH-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555952#comment-14555952
 ] 

Sean Owen commented on CRUNCH-524:
----------------------------------

I think an extra error message is fine. Yes deleteOnExit uses shutdown hooks 
and yes it will already be used anyway. It doesn't guarantee cleanup in case of 
a hard failure, but catches a lot of cases. You guys may know better than I 
where in the code these temp dirs could be explicitly cleaned up too. That's 
even better, rather than rely on a shutdown hook.

> Tests leave hbase, test.h2.db files around; pipeline leaves temp crunch-xxx 
> dirs around.
> ----------------------------------------------------------------------------------------
>
>                 Key: CRUNCH-524
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-524
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.12.0
>            Reporter: Sean Owen
>            Assignee: Josh Wills
>            Priority: Minor
>         Attachments: CRUNCH-524.patch
>
>
> Minor thing I noticed during running tests: I end up with an {{hbase/}} 
> directory and {{test.h2.db}} file in my _home directory_. I think the tests 
> can be changed to clean these up reliably or put them in a better place.
> Also I think we can get the {{/tmp/crunch-xxx}} dirs to be automatically 
> deleted. I see a lot in my temp dir and this happens on a cluster's temp dir 
> too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to