[ 
https://issues.apache.org/jira/browse/CRUNCH-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gabriel Reid updated CRUNCH-554:
--------------------------------
    Attachment: CRUNCH-554.patch

Patch to add MAX_COMPARABLES and MIN_COMPARABLES to the Aggregators class, also 
removes the existing min and max aggregators for various numeric types.

One extra thing I was considering was deprecating the MIN_<numeric type> and 
MAX_<numeric type> aggregators, with the suggestion to just use the 
MAX_COMPARABLES and MIN_COMPARABLES methods instead. Anyone have any thoughts 
either way on that?

> Add min and max aggregators for Comparables
> -------------------------------------------
>
>                 Key: CRUNCH-554
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-554
>             Project: Crunch
>          Issue Type: New Feature
>            Reporter: Gabriel Reid
>            Assignee: Gabriel Reid
>         Attachments: CRUNCH-554.patch
>
>
> In the Aggregators class, we currently have min and max aggregators for 
> various numeric types, but not for the general case of Comparables. We do 
> have this functionality in the MaxN and MinN aggregators, however.
> We should add MAX_COMPARABLES and MIN_COMPARABLES methods to the Aggregators 
> class. As extra bonus, all of the current numeric max and min aggregators can 
> be discarded and replaced with the comparable version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to