[ 
https://issues.apache.org/jira/browse/CRUNCH-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940671#comment-14940671
 ] 

mac champion edited comment on CRUNCH-565 at 10/2/15 1:33 AM:
--------------------------------------------------------------

Attached patch
Edit: forgot to mention, Configuration wasn't happy about me setting null for 
any values, so I skipped that test case. 


was (Author: champgm):
Attached patch

> CSVInputFormat needs to be more defensive when configuring itself
> -----------------------------------------------------------------
>
>                 Key: CRUNCH-565
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-565
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.10.0, 0.8.3
>            Reporter: mac champion
>            Assignee: mac champion
>            Priority: Minor
>              Labels: csv, csvparser
>         Attachments: 
> 0001-CRUNCH-565_CSVInputFormat-Configuration-Defensivenes.patch
>
>
> It seems that some behavior has changed somewhere along the line where hadoop 
> Configuration is concerned. It is possible that a call to .get(OPTION) will 
> return null. CSVInputFormat does not handle that case gracefully:
> https://github.com/apache/crunch/blob/apache-crunch-0.10.0/crunch-core/src/main/java/org/apache/crunch/io/text/csv/CSVInputFormat.java#L178-L183
> Some more relevant details can be found in this JIRA:
> https://issues.apache.org/jira/browse/CRUNCH-564?focusedCommentId=14938186&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14938186



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to