[ https://issues.apache.org/jira/browse/CRUNCH-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831145#comment-16831145 ]
Andrew Olson commented on CRUNCH-684: ------------------------------------- Yes I think your proposal makes sense. A quick review found all Targets extending FileTargetImpl similarly rely only on the Path value for evaluating uniqueness, however when the .fileSystem(fs) is used to select an alternative destination for the output data then we update the path to its filesystem-qualified form (we can reasonably expect that this happens prior to the target being supplied to the pipeline). > [crunch-hbase] HbaseTarget getting ignored even if configuration is different > ----------------------------------------------------------------------------- > > Key: CRUNCH-684 > URL: https://issues.apache.org/jira/browse/CRUNCH-684 > Project: Crunch > Issue Type: Improvement > Reporter: Keerthi Yanda > Priority: Minor > > *Current Scenario* > * We are trying to perform put operations for a table on different clusters > with the same table name. Below is the code that we are using to perform > write operation: > {code:java} > pipeline.write(PCollection<Put>, HbaseTarget, WriteMode.APPEND) > {code} > * Pipeline adds this target instance to "appendedTargets" and "outputTargets" > instances (which are HashSets) > *Issue:* > * As HbaseTarget's hashCode() and equals() methods are only checking for > tableName, HbaseTarget with different configuration properties is getting > ignored while adding it to appendedTargets/outputTargets. > *Proposal* > * Do we need to consider both tableName and "hbase.zookeeper.quorum" property > from "extraConf" to identify if the table(or hbaseTarget) is unique or not? > -- This message was sent by Atlassian JIRA (v7.6.3#76005)