[
https://issues.apache.org/jira/browse/CRUNCH-684?focusedWorklogId=236002&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-236002
]
ASF GitHub Bot logged work on CRUNCH-684:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/19 21:21
Start Date: 01/May/19 21:21
Worklog Time Spent: 10m
Work Description: noslowerdna commented on pull request #24: CRUNCH-684:
Fix .equals and .hashCode for Targets
URL: https://github.com/apache/crunch/pull/24
Previously the `equals` and `hashCode` methods for the `Target`
implementations Crunch provides did not consider all available information when
determining uniqueness. `FileTargetImpl` only used the path, and `HBaseTarget`
only the table name. This could result in situations where a target was
silently ignored because of how a `Set` is used in various places for holding a
pipeline's collection of targets. For HBase especially, the
`hbase.zookeeper.quorum` configuration if supplied can change where the table
actually resides.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 236002)
Time Spent: 10m
Remaining Estimate: 0h
> [crunch-hbase] HbaseTarget getting ignored even if configuration is different
> -----------------------------------------------------------------------------
>
> Key: CRUNCH-684
> URL: https://issues.apache.org/jira/browse/CRUNCH-684
> Project: Crunch
> Issue Type: Improvement
> Reporter: Keerthi Yanda
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> *Current Scenario*
> * We are trying to perform put operations for a table on different clusters
> with the same table name. Below is the code that we are using to perform
> write operation:
> {code:java}
> pipeline.write(PCollection<Put>, HbaseTarget, WriteMode.APPEND)
> {code}
> * Pipeline adds this target instance to "appendedTargets" and "outputTargets"
> instances (which are HashSets)
> *Issue:*
> * As HbaseTarget's hashCode() and equals() methods are only checking for
> tableName, HbaseTarget with different configuration properties is getting
> ignored while adding it to appendedTargets/outputTargets.
> *Proposal*
> * Do we need to consider both tableName and "hbase.zookeeper.quorum" property
> from "extraConf" to identify if the table(or hbaseTarget) is unique or not?
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
