[ 
https://issues.apache.org/jira/browse/CURATOR-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13856923#comment-13856923
 ] 

Jordan Zimmerman commented on CURATOR-33:
-----------------------------------------

My initial view of the change is good. However, I'd like to see more tests. For 
example, processChildren() can cause a getDataAndStat() and then an 
internalRefresh(). This smells like a potential race, but I'd need to prove it.

So, please provide some more tests. Maybe create a new test class dedicated to 
testing DescendantHandlingMode.ALL_DESCENDANTS

> Recursive Node Cache
> --------------------
>
>                 Key: CURATOR-33
>                 URL: https://issues.apache.org/jira/browse/CURATOR-33
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Recipes
>            Reporter: John Vines
>             Fix For: awaiting-response
>
>         Attachments: CURATOR-33.patch
>
>
> Currently the PathChildrenCache will trigger listen events for all children 
> at the given node. However, it would be useful to have a cache that would 
> trigger listen events for the entire hierarchy below the given node.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to