[ 
https://issues.apache.org/jira/browse/CURATOR-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028666#comment-14028666
 ] 

Cameron McKenzie commented on CURATOR-110:
------------------------------------------

I've had another chance to look at this, and have most of it working. As 
discussed, we need to make the start() method spawn a thread to maintain 
current behaviour (i.e something that returns straight away, instead of 
blocking until a connection is established). Are you happy for this to just be 
a one off 'new Thread(new Runnable())' approach? There doesn't seem to be any 
benefit in using an executor in this case to me.

> LeaderLatch does not complete if it is started without a connection to 
> ZooKeeper
> --------------------------------------------------------------------------------
>
>                 Key: CURATOR-110
>                 URL: https://issues.apache.org/jira/browse/CURATOR-110
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 2.5.0
>            Reporter: Cameron McKenzie
>            Priority: Minor
>              Labels: connection, latch, leader
>             Fix For: 2.6.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Given the following conditions:
> 1.) No connection is available to ZK
> 2.) A LeaderLatch is created and started
> 3.) All retries for the leader latch creating its ephemeral zNode have been 
> exhausted.
> At this point the LeaderLatch will not begin functioning correctly when a 
> connection is established. This is due to it ignoring 'CONNECTED' connection 
> state events (it only handles RECONNECTED events).
> The fix should simply be a case of making the state handling for CONNECTED 
> and RECONNECTED the same.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to