Github user cammckenzie commented on a diff in the pull request:
https://github.com/apache/curator/pull/9#discussion_r13730278
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -162,6 +166,21 @@ public void process(WatchedEvent watchedEvent)
failedDeleteManager = new FailedDeleteManager(this);
namespaceFacadeCache = new NamespaceFacadeCache(this);
+
+ //Add callback handler to determine connection state transitions
+ getConnectionStateListenable().addListener(new
ConnectionStateListener()
--- End diff --
We need to get updates on when the state changes, otherwise we'd need to
keep polling the connectionStateManager for connection state changes. This is
only needed if the blocking until connected logic is implemented in the
CuratorFramework. If we use the CuratorZooKeeperClient instead, it can be
removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
