Github user cammckenzie commented on the pull request:
https://github.com/apache/curator/pull/9#issuecomment-46244024
The ConnectionState.isConnected() is being used is in the
CuratorFrameworkImpl when we're blocking for a connection. I think that leaving
it in is probably not a bad idea, as it's still got potential to be useful in
other places too.
In regards to the tests, I wonder if there's a way of structuring them to
be more event driven rather than just waiting some arbitrary amount of time and
hope an event occurs within that window? I'll have a look and see if I can find
anything, but that's for another JIRA ticket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---