Using "mvn -DautoVersionSubmodules=true" will save you a lot of time here in the future. I'll open a JIRA and provide a patch later this week.
On Mon, Jul 7, 2014 at 9:24 PM, Cameron McKenzie <[email protected]> wrote: > Ok, just to confirm before I go down the slippery slope. > Version number for each component should be bumped to 2.6.0, and then the > defaults should just be used for everything else? > > What is the release version for "Apache Curator"? > (org.apache.curator:apache-curator) 2.5.1: : 2.6.0 > > What is the release version for "Curator Testing"? > (org.apache.curator:curator-test) 2.5.1: : 2.6.0 > > What is the release version for "Curator Client"? > (org.apache.curator:curator-client) 2.5.1: : 2.6.0 > > What is the release version for "Curator Framework"? > (org.apache.curator:curator-framework) 2.5.1: : 2.6.0 > > What is the release version for "Curator Recipes"? > (org.apache.curator:curator-recipes) 2.5.1: : 2.6.0 > > What is the release version for "Curator Service Discovery"? > (org.apache.curator:curator-x-discovery) 2.5.1: : 2.6.0 > > What is the release version for "Curator Examples"? > (org.apache.curator:curator-examples) 2.5.1: : 2.6.0 > > What is the release version for "Curator Service Discovery Server"? > (org.apache.curator:curator-x-discovery-server) 2.5.1: : 2.6.0 > > What is the release version for "Curator RPC Proxy"? > (org.apache.curator:curator-x-rpc) 2.5.1: : 2.6.0 > > What is SCM release tag or label for "Apache Curator"? > (org.apache.curator:apache-curator) apache-curator-2.6.0: : > > What is the new development version for "Apache Curator"? > (org.apache.curator:apache-curator) 2.6.1-SNAPSHOT: : > > What is the new development version for "Curator Testing"? > (org.apache.curator:curator-test) 2.6.1-SNAPSHOT: : > > What is the new development version for "Curator Client"? > (org.apache.curator:curator-client) 2.6.1-SNAPSHOT: : > > What is the new development version for "Curator Framework"? > (org.apache.curator:curator-framework) 2.6.1-SNAPSHOT: : > > What is the new development version for "Curator Recipes"? > (org.apache.curator:curator-recipes) 2.6.1-SNAPSHOT: : > > What is the new development version for "Curator Service Discovery"? > (org.apache.curator:curator-x-discovery) 2.6.1-SNAPSHOT: : > > What is the new development version for "Curator Examples"? > (org.apache.curator:curator-examples) 2.6.1-SNAPSHOT: : > > What is the new development version for "Curator Service Discovery Server"? > (org.apache.curator:curator-x-discovery-server) 2.6.1-SNAPSHOT: : > > What is the new development version for "Curator RPC Proxy"? > (org.apache.curator:curator-x-rpc) 2.6.1-SNAPSHOT: : > > > On Tue, Jul 8, 2014 at 12:21 PM, Jordan Zimmerman < > [email protected]> wrote: > > > I’ve never actually done a dry run. We should change the wiki. I’m not > > sure rollback actually works. You can do a > > > > mvn release:clean > > > > instead. > > > > On July 7, 2014 at 9:18:02 PM, Cameron McKenzie ([email protected]) > > wrote: > > > > The mvn release:rollback target is failing. It's complaining that it > can't > > do the git commit. I'm also seeing a lot of warnings about the following: > > > > [WARNING] Ignoring unrecognized line: ?? curator-client/pom.xml.next > > > > [WARNING] Ignoring unrecognized line: ?? > > curator-client/pom.xml.releaseBackup > > > > [WARNING] Ignoring unrecognized line: ?? curator-client/pom.xml.tag > > > > [WARNING] Ignoring unrecognized line: ?? curator-examples/pom.xml.next > > > > The last commands are below: > > > > [INFO] Executing: /bin/sh -c cd /Users/cam/Documents/workspace/curator && > > git commit --verbose -F > > > /var/folders/ms/n6xxr6dd4dxb3dhth1k31s0r0000gn/T/maven-scm-1233534200.commit > > pom.xml curator-test/pom.xml curator-client/pom.xml > > curator-framework/pom.xml curator-recipes/pom.xml > > curator-x-discovery/pom.xml curator-examples/pom.xml > > curator-x-discovery-server/pom.xml curator-x-rpc/pom.xml > > > > [INFO] Working directory: /Users/cam/Documents/workspace/curator > > > > [INFO] > > ------------------------------------------------------------------------ > > > > [INFO] Reactor Summary: > > > > [INFO] > > > > [INFO] Apache Curator ..................................... FAILURE [ > > 2.317 s] > > > > [INFO] Curator Testing .................................... SKIPPED > > > > [INFO] Curator Client ..................................... SKIPPED > > > > [INFO] Curator Framework .................................. SKIPPED > > > > [INFO] Curator Recipes .................................... SKIPPED > > > > [INFO] Curator Service Discovery .......................... SKIPPED > > > > [INFO] Curator Examples ................................... SKIPPED > > > > [INFO] Curator Service Discovery Server ................... SKIPPED > > > > [INFO] Curator RPC Proxy .................................. SKIPPED > > > > [INFO] > > ------------------------------------------------------------------------ > > > > [INFO] BUILD FAILURE > > > > [INFO] > > ------------------------------------------------------------------------ > > > > [INFO] Total time: 4.523 s > > > > [INFO] Finished at: 2014-07-08T12:15:58+10:00 > > > > [INFO] Final Memory: 11M/81M > > > > [INFO] > > ------------------------------------------------------------------------ > > > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-release-plugin:2.5:rollback (default-cli) > on > > project apache-curator: Unable to commit files > > > > [ERROR] Provider message: > > > > [ERROR] The git-commit command failed. > > > > [ERROR] Command output: > > > > [ERROR] -> [Help 1] > > > > > > On Tue, Jul 8, 2014 at 12:05 PM, Jordan Zimmerman < > > [email protected]> wrote: > > > >> Yeah - that looks right. > >> > >> On July 7, 2014 at 9:05:06 PM, Cameron McKenzie ([email protected] > ) > >> wrote: > >> > >> This is the expected diff between pom.xml and pom.xml.tag? > >> > >> [cam:~/Documents/workspace/curator] cam% diff pom.xml pom.xml.tag > >> > >> 31c31 > >> > >> < <version>2.5.1-SNAPSHOT</version> > >> > >> --- > >> > >> > <version>2.6.0</version> > >> > >> 105c105 > >> > >> < <tag>HEAD</tag> > >> > >> --- > >> > >> > <tag>apache-curator-2.6.0</tag> > >> > >> > >> On Tue, Jul 8, 2014 at 11:31 AM, Jordan Zimmerman < > >> [email protected]> wrote: > >> > >>> Yes - marked it as fixed. > >>> > >>> On July 7, 2014 at 8:30:38 PM, Cameron McKenzie ( > [email protected]) > >>> wrote: > >>> > >>> Ok, final question (I hope) for now. Do I just close the CURATOR-116 > >>> JIRA ticket? > >>> > >>> > >>> On Tue, Jul 8, 2014 at 11:27 AM, Jordan Zimmerman < > >>> [email protected]> wrote: > >>> > >>>> No - we’re using semantic versioning. There’s some API changes as I > >>>> recall. Also, this release has the new Curator-RPC. It should be > 2.6.0. > >>>> > >>>> -Jordan > >>>> > >>>> On July 7, 2014 at 7:53:30 PM, Cameron McKenzie ( > [email protected]) > >>>> wrote: > >>>> > >>>> Once I've merged CURATOR-116, I'll do a release. I presume that this > >>>> should be a 2.5.2? > >>>> > >>>> > >>>> On Tue, Jul 8, 2014 at 7:56 AM, Jordan Zimmerman < > >>>> [email protected]> wrote: > >>>> > >>>>> Up to you. You might want to push CURATOR-116 first. Once you’re > >>>>> ready, follow the steps here (updating them if needed): > >>>>> > https://cwiki.apache.org/confluence/display/CURATOR/For+Curator+Committers#ForCuratorCommitters-release-curator > >>>>> > >>>>> -Jordan > >>>>> > >>>>> On July 7, 2014 at 4:54:06 PM, Cameron McKenzie ( > >>>>> [email protected]) wrote: > >>>>> > >>>>> Yep, I'm happy to do the release, just let me know when you'd like > >>>>> me to go > >>>>> forward. > >>>>> cheers > >>>>> > >>>>> > >>>>> On Tue, Jul 8, 2014 at 1:20 AM, Jordan Zimmerman < > >>>>> [email protected] > >>>>> > wrote: > >>>>> > >>>>> > Looks like we have enough issues closed for a 2.6.0 release. > >>>>> Thoughts? > >>>>> > Cameron, it would be good for you to do the next release if you > >>>>> don’t mind. > >>>>> > > >>>>> > > >>>>> > > >>>>> > https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+CURATOR+AND+fixVersion+%3D+2.6.0+ORDER+BY+updated+DESC%2C+priority+DESC%2C+created+ASC&mode=hide > >>>>> > > >>>>> > -Jordan > >>>>> > > >>>>> > > >>>>> > >>>>> > >>>> > >>> > >> > > >
