-1 (non-binding) Verified signature and hashes, all good.
The git tag does not match the source zip: * zip contains a file called .test.swp * zip differs from tag on curator-x-rpc/dependency-reduced-pom.xml (brought up in the other thread) Missing licence headers: * curator-x-rpc/pom.xml * curator-x-rpc/dependency-reduced-pom.xml * curator-x-rpc/src/main/thrift/curator.thrift * curator-x-rpc/src/main/resources/curator/help.txt * curator-x-rpc/src/test/resources/configuration/connections.json * curator-x-rpc/src/test/resources/configuration/logging.json * curator-x-rpc/src/test/resources/configuration/simple.json * curator-x-rpc/src/test/resources/configuration/test.json Incomplete licence header: * doap.rdf Attempted to build from source: mvn clean verify * Compiled cleanly! * Had a test failure in TestDistributedDelayQueue.testSorting() (fixed in master) * Had a intermittent test failure in TestDistributedQueue.testCustomExecutor() (will investigate further) On Wed, Jul 9, 2014 at 6:47 AM, Eric Tschetter <[email protected]> wrote: > +1 > > On Wednesday, July 9, 2014, Ashish <[email protected]> wrote: > > > +1 (non-binding) > > > > Ran the build. Works fine and all test cases passed > > > > > > On Wed, Jul 9, 2014 at 5:31 AM, Jordan Zimmerman < > > [email protected] <javascript:;> > > > wrote: > > > > > Validated keys > > > > > > +1 > > > > > > > > > On July 8, 2014 at 5:08:37 PM, Cameron McKenzie ( > [email protected] > > <javascript:;>) > > > wrote: > > > > > > Hello, > > > > > > This is the vote for Apache Curator version 2.6.0 > > > > > > *** Please download, test and vote within approx. 72 hours > > > > > > Note that we are voting upon the source (tag) and binaries are > > > provided for convenience. > > > > > > Link to release > > > notes: > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425&version=12327098 > > > > > > Staging repo:https://dist.apache.org/repos/dist/dev/curator/2.6.0/ > > > > > > Binary artifacts: > > > > https://repository.apache.org/content/repositories/orgapachecurator-1004 > > > > > > > > > The tag to be voted > > > upon: > > > > > > https://git-wip-us.apache.org/repos/asf?p=curator.git;a=tag;h=apache-curator-2.6.0 > > > > > > Curator's KEYS file containing PGP keys we use to sign the > > > release:http://www.apache.org/dist/curator/KEYS > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove (and reason why) > > > > > > > > > cheers > > > > > > Cam > > > > > > > > > > > -- > > thanks > > ashish > > > > Blog: http://www.ashishpaliwal.com/blog > > My Photo Galleries: http://www.pbase.com/ashishpaliwal > > >
