Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15488051
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -74,7 +71,7 @@
private final NamespaceFacadeCache namespaceFacadeCache;
private final NamespaceWatcherMap namespaceWatcherMap = new
NamespaceWatcherMap(this);
- private volatile ExecutorService executorService;
+ private volatile Thread backgroundThread;
--- End diff --
I'm just concerned it's a larger problem. Executors are used throughout
Curator and I've relied on shutdownNow to work correctly. I didn't know about
the bug. So, I'd feel better having an open issue to deal with it directly.
Curator already has the CloseableExecutorService wrapper and my gut feeling is
that it can be fixed inside of there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
